Add option to upload to other servers
Submitted by jeyca
Assigned to Jérôme Guelfucci
Description
currently there are options to immediately upload screenshots to imgur or or zimagez, but they both use trackers or one needs to register. It would be a big privacy improvement to have the chance uploading images to Framapic.org, where they will be stored encrypted, no trackers are used and you don't need to register.
In general it would be great to be able to integrate any custom server/apis.
Version: 1.8.2
Activity
@andreldmsaid:Actually only imgur now that zimagez is dead (support removed in 1.9.2). I plan to implement a feature to allow "custom action" so the user can literally do whatever he/she wants with the screenshots, for instance upload to any service out there. Unfortunately it won't happen before Xfce 4.14, all my spare time is focused on getting other components ready :)
-
Andre I have tried to include an option to upload to the IPFS(https://en.wikipedia.org/wiki/InterPlanetary_File_System): https://github.com/amar-laksh/xfce-screenshooter-ipfs-support
How do I go about pushing it to mainstream?
-
@andreldmsaid:Hi, IPFS seems a nice hosting option and code-wise it looks good to me (expect for some formatting problems). However my concern is: if IPFS changes its API we need update that code and release screenshooter, and it takes some (a long?) time to it reach users. It's not a problem with your code itself, but I considering to change how external services are handled. Therefore I'm not sure it is interesting to add any service just to change later.
-
Hey Andre,
I completely agree that depending on external APIs is really not the way to go. But I had questions:
-
My fork specifically relies on a third-party service(https://globalupload.io/) so I get that's bad but is it specifically the API breakage from the perspective of IPFS that you are worried?
-
If you are worried about IPFS then that relying on Imgur should also be seen as a negative, shouldn't it?
-
I do also wanted to admit that my fork adds json-glib as an additional dependency but that I believe is something that can be discussed later.
Thanks! Will be waiting eagerly for responses!
-
-
@andreldmsaid:I'm not concerned about IPFS, imgur might let us down all the same. Let me try to explain my point of view more carefully:
What really worries me is that whenever someone asks to add one service, it takes that effort you had and that many lines of code. Suppose we push the IPFS and Framapic support, then a few more services, after that there will be more code to upload images than else. And with that the responsibility to maintain all API breakages, bugs and security issues. I feel that this approach is not optimal, perhaps naive, so there must be a solution that pleases users and keeps xfce4-screenshooter simple and small.
My hypothesis is something like custom actions (similar to Thunar's) external to xfce4-screenshooter binary. They could be:
- Shell scripts in XDG_CONFIG_HOME -> Easy to support but kinda hackish, error-prone and insecure. Maybe allow any type of script (python, javascript).
- Shared libraries (plugins) -> harder to supporter, not customizable by end users.
- Properties files describing things such as: URL, timeout, how to build the payload, how to get results and etc. -> Easy for end users, but I don't think it's viable, too hard to describe behavior (handling).
Anyway, there's nothing planed, consider this more of a RFC. In the end, I can add support to IPFS and Framapic just to see how this evolves.
With regards to json-glib, also looks good to me, it seems to be present in major distributions. I wish to get rid libsoup and libxml at some point, so it will be useful.
-
Hi,
I was facing the same issues when I was still maintaining.
Just a note, creating a custom action has been possible for a while but not trivial by creating a script / app to upload a file and a desktop file pointing to this script and registering PNG (if I remember correctly) as a handled MimeType. If nothing changed, the custom action should then show up in the Applications drop down.
I hope this is of any help,
Cheers,
Jerome
-
@andreldmsaid:Thanks Jérôme for you insight, it's certainly helpful. I think will go with the naive approach for now, i.e. add hard-coded services, try to isolate common code and strive for reuse... that proposal will need to wait for a future version (1.10.x or 2.0.x). But it's nice to know that workaround/hack, I'll give it a try and maybe write a blog post about it.
-
@andreldmclosed a related bug:*** Bug 12642 has been marked as a duplicate of this bug. ***
mentioned in issue #9 (closed)
added 2. Feature 5. Save Window labels
@andreldm: tagging you in. I closed #9 (closed) as @ochosi said bug 12642 would have solved it, which was closed as a duplicate of this, though #9 (closed) is about expanding imgur's ability to save to a user's account.
added 5. Upload Services label
Closing in favor of #48 (closed)