Skip to content
Snippets Groups Projects
Commit 1f687b75 authored by Jerome Guelfucci's avatar Jerome Guelfucci
Browse files

Fix four memleaks detected by Gauvain Pocentek.

(Old svn revision: 5512)
parent cd63a5bf
No related branches found
No related tags found
No related merge requests found
2008-10-05 jeromeg
* Plug some leaks detected by Gauvain Pocentek:
- src/main.c: in (main), free sd->screenshot_dir before setting the new
value from command line.
- src/screenshooter-utils.c: in (save_screenshot), free filename before
getting the user set filename.
2008-10-04 jeromeg
* Partially refactor the code:
......
......@@ -191,10 +191,12 @@ int main(int argc, char **argv)
/* Check if the path is absolute, if not make it absolute */
if (g_path_is_absolute (screenshot_dir))
{
sd->screenshot_dir = screenshot_dir;
g_free (sd->screenshot_dir);
sd->screenshot_dir = screenshot_dir;
}
else
{
g_free (sd->screenshot_dir);
sd->screenshot_dir =
g_build_filename (g_get_current_dir (), screenshot_dir, NULL);
g_free (screenshot_dir);
......
......@@ -240,6 +240,7 @@ void save_screenshot (GdkPixbuf *screenshot, gboolean show_save_dialog,
if (dialog_response == GTK_RESPONSE_ACCEPT)
{
g_free (filename);
filename =
gtk_file_chooser_get_filename (GTK_FILE_CHOOSER (chooser) );
gdk_pixbuf_save (screenshot, filename, "png", NULL, NULL);
......@@ -249,9 +250,13 @@ void save_screenshot (GdkPixbuf *screenshot, gboolean show_save_dialog,
}
else
{
gchar * savename = NULL;
/* Else, we just save the file in the default folder */
filename = g_build_filename (default_dir, filename, NULL);
gdk_pixbuf_save (screenshot, filename, "png", NULL, NULL);
savename = g_build_filename (default_dir, filename, NULL);
gdk_pixbuf_save (screenshot, savename, "png", NULL, NULL);
g_free (savename);
}
g_free (filename);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment