This function is duplicated in gs-window-x11.c and
xfce4-screensaver-preferences.c.

Merge the two implementations in xfce-desktop-utils.c and use that
one.

Also, instead of copying environ directly, use g_get_environ().

This hides warnings or other useful messages that should be accessible
without enabling debug mode. On the other hand some warnings should be
lowered to debug level, e.g. AccountsService may not be installed.

Matias De lellis authored 3 years ago and Gaël Bonithon committed 2 years ago

All user dialogs (Linux, Windows, Mac, Android, etc..), or any
representation of a user as an avatar in the web are round
images.

Also, it shows an emblem icon to note that it is logged in as
in other dialogs.

Both options can be made configurable by the user very easily,
but at least (IMHO of course), I think it respects the
preference of the majority of users.

Błażej Szczygieł authored 2 years ago and Gaël Bonithon committed 2 years ago

Always remove sleep inhibit. Fixes few seconds delay when sleeping with
screen locker disabled.

Amends: f2d07a37

Fixes: 7aeced1f

xfconf_channel_get() is transfer none contrary to what the doc says, and
each call of xfconf_init() must be followed by a call of
xfconf_shutdown().

In particular, fixes an unref-critical when closing the prefs dialog.

Maciej S. Szmigiero authored 3 years ago and Gaël Bonithon committed 2 years ago

dialog_timed_out() returns FALSE to remove its GSource but does not zero
the related timeout_id variable which can result in later removal of a
different event source that happen to reuse this id.

Lance Arsenault authored 2 years ago and Gaël Bonithon committed 2 years ago

Fixes: #99
MR: !18

ENABLE_NLS is rarely used and will no longer be supported by
xfce4-dev-tools 4.18.

OlivierDuchateau authored 5 years ago and Sean Davis committed 4 years ago

Signed-off-by: Sean Davis <smd.seandavis@gmail.com>

This reverts commit 378c7881.

This reverts commit 37b96373.

O H authored 4 years ago and Sean Davis committed 4 years ago

Similar code to prevent a crash exits elsewhere.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

This reverts commit f596f888.

Fixes #66

O H authored 4 years ago and Sean Davis committed 4 years ago

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

g_timeout_add_seconds expects a guint as first argument.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

g_idle_add expects a GSourceFunc as first argument.
Remove the casts and add proper prototype to affected functions.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

g_timeout_add_full expects a GSourceFunc as third argument.
Remove the casts and add proper prototype to affected functions.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

g_timeout_add_seconds expects a GSourceFunc as second argument.
Remove the casts and add proper prototype to affected functions.

Remove unneeded prototype for activate_dpms_timeout and deepsleep_idle.
Remove suffix from response_cancel_idle.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

date_time_update is called repeately by a timer.
To keep the timer active it has to return TRUE.

Handle OOM while being here.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

idle_time and lock_time are unsigned values.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

Each call to get_x11_idle_info was allocating a new XScreenSaverInfo.

Adjust the function to check the result, print the raw value in debug mode,
and let the caller know about potential failures.

Keep the timer active in case of OOM.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

The used API g_timer_elapsed() returns a double instead of a struct timespec,
convert the result prior comparison.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

Change all callers with large milliseond values to use seconds instead.
This is supposed to make it clearer how long the interval is.

No change in behavior intented.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

O H authored 4 years ago and Sean Davis committed 4 years ago

Signed-off-by: Olaf Hering <olaf@aepfle.de>

In cases where the dbus connection fails, gs_listener_dbus_init
will fail and return FALSE. Previously, this status code was not
checked in the gs_listener constructor, resulting in a silent failure
that eventually resulted in a Segmentation Fault when the listener's
system_connection pointer gets used.

Add a g_assert to ensure gs_listener_dbus_init succeeds, or bail out
gracefully on failures.