Skip to content
Snippets Groups Projects
Forked from Apps / xfce4-screenshooter
Source project has a limited visibility.
  • Evangelos Foutras's avatar
    07dfa8e1
    Implement alternate fix for crash on upload (#11879) · 07dfa8e1
    Evangelos Foutras authored
    The original fix complicated the code by individually allocating GValue
    objects and then storing pointers to them in the job parameters array.
    
    While the crash on upload was fixed, the program would still crash on
    exit due to the clear_func used for the array (g_free); as per GLib's
    documentation, "clear_func is expected to clear the contents of the
    array element it is given, but not free the element itself".
    
    The minimal fix in this commit should fix the original issue, and also
    the crash on program exit (bug #13684).
    07dfa8e1
    History
    Implement alternate fix for crash on upload (#11879)
    Evangelos Foutras authored
    The original fix complicated the code by individually allocating GValue
    objects and then storing pointers to them in the job parameters array.
    
    While the crash on upload was fixed, the program would still crash on
    exit due to the clear_func used for the array (g_free); as per GLib's
    documentation, "clear_func is expected to clear the contents of the
    array element it is given, but not free the element itself".
    
    The minimal fix in this commit should fix the original issue, and also
    the crash on program exit (bug #13684).