Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xfwm4 xfwm4
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
  • Issues 363
    • Issues 363
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 42
    • Merge requests 42
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • XfceXfce
  • xfwm4xfwm4
  • Merge requests
  • !90

client: clientConfigure: simplify catching border_width

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Enrico Weigelt requested to merge metux/xfwm4:submit/clientConfigure_border_width into master Nov 09, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Along the clientConfigure() call path, we're catching up potential changes in window's border_width attribute into internal state, used on reparenting. Potential sources are intercepted configure requests and netwm hints. Deep down the road (clientConfigureWindows()) the corresponding mask flag is cleared, so this change isn't passed to the Xserver - we just record it.

In order to improve code clarity, making a clear border between recording changes and applying our current state, moving this further up the call chain, near to where the data arrives, into clientMoveResizeWindow().

With more subsequent patches, we'll reach a point where clientConfigure() doesn't touch any internal state anymore (except applying constraints), but just writing out what we already have.

Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: submit/clientConfigure_border_width