Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • xfwm4 xfwm4
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
  • Issues 369
    • Issues 369
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 49
    • Merge requests 49
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • XfceXfce
  • xfwm4xfwm4
  • Merge requests
  • !74

Cleanup: client: clientNewMaxSize() pass rect as stack value instead of pointer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Enrico Weigelt requested to merge metux/xfwm4:submit/clientnewmaxsize into master Nov 04, 2022
  • Overview 1
  • Commits 4
  • Pipelines 7
  • Changes 3

It doesn't make sense to pass it as reference, since it's no output parameter and the function really shouldn't ever change the caller's field - thus reference isn't actually semantically correct.

As a nice by product, the compiler now can duplicate it directly from stack to stack (cached and fast) as one block (even use string ops) and do further access from there, instead of indirectly addressing one by one via slow far pointers.

Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: submit/clientnewmaxsize