Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xfwm4 xfwm4
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
  • Issues 363
    • Issues 363
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 42
    • Merge requests 42
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • XfceXfce
  • xfwm4xfwm4
  • Merge requests
  • !64

drop non functional gtk cursor theme

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Enrico Weigelt requested to merge metux/xfwm4:submit/drop-unused-update-cursor into master Oct 27, 2022
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 3

Since we're using Xserver's builtin cursor font, the whole code reacting Gtk cursors theme signals isn't doing anything useful at all - it just recreates the cursors from the same source they originally came from and readjust them for all clients, practically doesn't change anything.

IOW: we haven't any cursor theming in xfwm at all, just many Loc that don't do anything useful.

If we'll actually implement that feature, it should be quite different in several places:

  1. directly use XSETTINGS spec instead of proprietary Gtkisms
  2. carefully consider extending the spec to to also store the actual cursors (instead of just the theme name - since remote client don't necessarily have the same themes)
  3. do it in ScreenInfo instead of DisplayInfo - since xsettings operates on root window, thus on Xscreen instead of Xdisplay.

Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: submit/drop-unused-update-cursor