Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xfwm4 xfwm4
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
  • Issues 363
    • Issues 363
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 42
    • Merge requests 42
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • XfceXfce
  • xfwm4xfwm4
  • Merge requests
  • !52

Cleanup: wireframe: optimize away unncessary getter calls

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Enrico Weigelt requested to merge metux/xfwm4:submit/wireframe-optimize into master Oct 06, 2022
  • Overview 0
  • Commits 1
  • Pipelines 7
  • Changes 1

We've got lots of getter function calls, just to retrieve some pointers that are used many times in the same function - which is unncessary boilerplate and consumes extra cycles. It's enough to fetch them once and keep them on stack/register.

Since wireframeDraw*() are static and have exactly one caller, the compiler can rewrite them to use the parameters from caller's stack, effectively inline these functions.

Edited Oct 12, 2022 by Enrico Weigelt
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: submit/wireframe-optimize