Skip to content

settings-dialogs: Fix string leaks

correctmost requested to merge correctmost/xfwm4:cm/fix-sort-leaks into master

Leak report

555 bytes in 98 blocks are definitely lost in loss record 11,928 of 12,446
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x5875721: g_malloc (gmem.c:100)
   by 0x588EED3: g_strdup (gstrfuncs.c:323)
   by 0x57F7A26: g_strdup_inline (gstrfuncs.h:321)
   by 0x57F7A26: value_lcopy_string (gvaluetypes.c:316)
   by 0x5124B38: gtk_tree_model_get_valist (gtktreemodel.c:1812)
   by 0x5124D24: gtk_tree_model_get (gtktreemodel.c:1774)
   by 0x10E6F1: xfwm_settings_theme_sort_func (xfwm4-settings.c:720)
   by 0x501EBE0: gtk_list_store_compare_func (gtkliststore.c:1970)
[...snip...]

679 bytes in 89 blocks are definitely lost in loss record 11,981 of 12,446
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x5875721: g_malloc (gmem.c:100)
   by 0x588EED3: g_strdup (gstrfuncs.c:323)
   by 0x57F7A26: g_strdup_inline (gstrfuncs.h:321)
   by 0x57F7A26: value_lcopy_string (gvaluetypes.c:316)
   by 0x5124B38: gtk_tree_model_get_valist (gtktreemodel.c:1812)
   by 0x5124D24: gtk_tree_model_get (gtktreemodel.c:1774)
   by 0x10E710: xfwm_settings_theme_sort_func (xfwm4-settings.c:721)
   by 0x501EBE0: gtk_list_store_compare_func (gtkliststore.c:1970)
[...snip...]

Testing

  • No issues were detected when testing the patch with Valgrind

Merge request reports