Context-menu icon "fullscreen" naming inconsistency
Submitted by Simon Steinbeiß @ochosi
Assigned to Olivier Fourdan @olivier
Description
Created attachment 4478 Fullscreen icon is scaled, while maximize isn't
With the new feature of customizable context-menu icons (installed in hicolor/22x22/actions/xfce-wm*) I noticed that the "fullscreen" and "leave fullscreen" icons are identical (see http://git.xfce.org/xfce/xfwm4/tree/src/menu.c#n56 and the following line).
While this might not pose a problem in itself (you could argue that in fullscreen-mode this menu isn't really visible), i'm not sure the naming makes sense. Either Xfwm follows Gnome, but in this case it should use "gtk-leave-fullscreen" for MENU_OP_UNFULLSCREEN (http://developer.gnome.org/gtk/2.24/gtk-Stock-Items.html), or it follows the freedesktop.org icon specification(http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html), in which case the correct name of the icon/s would be "view-fullscreen".
Feel free to call me petty for worrying about such a small detail, but maintain an icon theme for more than 6 months and you'll see how annoying inconsistencies can be in this respect :)
A second issue that probably should go into a different bugreport: somehow the icon-scaling is different for the gtk-fullscreen icon. I simply created a symlink for testing in hicolor/22x22/actions from maximize to gtk-fullscreen, and for some reason the fullscreen icon gets scaled down. (Screenshot attached)
Attachment 4478, "Fullscreen icon is scaled, while maximize isn't":
Version: 4.10.0