"Draw frame around selected windows while cycling" does not draw if previously highlighted window is the same size as current window

Submitted by jsp..@..il.com

Assigned to Olivier Fourdan @olivier

Link to original bug (#13747)

Description

Created attachment 7244 frame.patch

On one of my virtual desktops, I have 4 identically-sized Xterm windows. When I cycle through the windows with Alt-Tab, the first window gets outlined, but when I press Tab again, the next window does not get outlined. If I open a window that is a different size, then it gets outlined as I cycle through.

I looked through the source code and found the following suspicious block of code in src/wireframe.c:

if ((width == wireframe->width) && (height == wireframe->height))
{
    /* Moving only */
    return;
}

I removed this block, and that fixed the bug for me.

Patch 7244, "frame.patch":
file_13747.txt

Version: 4.12.0