Visual feed back when switching workspaces

Matt submitted a patch:

Here is a patch that adds the functionality. It's a little rough around the edges, but the core functionality works. It still needs to be integrated with the themes, properties need to be added for styling, and it would be nice to allow this to be enabled/disabed in the XFWM4 perferences.

Patch 5174, "visual feed back on worskspace change patch":
0001-Squashed-commit-of-the-following.patch

Shuhao said:

I've been asking for this feature for a while now, I'll give it a test run for sure!

Simon Steinbeiß @ochosi said:

I've tested the patch and it works nicely and as expected. I also second the feature-request.

Olivier Fourdan @olivier said:

Needs rebase
Please stash some commits, there is no point in carrying over things like "fix code whitespace formatting"
"add support for move with focued window" typo
"beautifiy workspace drawing in wswinwidget" typo

modifiers = (screen_info->params->keys[KEY_MOVE_UP_WORKSPACE].modifier |

            screen_info->params->keys[KEY_MOVE_DOWN_WORKSPACE].modifier |

            screen_info->params->keys[KEY_MOVE_LEFT_WORKSPACE].modifier |

            screen_info->params->keys[KEY_MOVE_RIGHT_WORKSPACE].modifier |

            screen_info->params->keys[KEY_LEFT_WORKSPACE].modifier |

            screen_info->params->keys[KEY_RIGHT_WORKSPACE].modifier |

            screen_info->params->keys[KEY_UP_WORKSPACE].modifier |

            screen_info->params->keys[KEY_DOWN_WORKSPACE].modifier);

You mean "||", not "|" (logical OR)

           if (key == KEY_MOVE_UP_WORKSPACE |

               key == KEY_MOVE_DOWN_WORKSPACE |

               key == KEY_MOVE_LEFT_WORKSPACE |

               key == KEY_MOVE_RIGHT_WORKSPACE)

Again, same here

```
       if (key == KEY_UP_WORKSPACE |
```
```
           key == KEY_DOWN_WORKSPACE |
```
```
           key == KEY_LEFT_WORKSPACE |
```
```
           key == KEY_RIGHT_WORKSPACE)
```

And here

```
   //TRACE ("event loop now finished");
```

Please void using C++ comment (I know C99 allows this, but still)

       //if((wsw->undrawn == FALSE) && (current != wswin->selected) && (current != wswin->previous))

```
       //    continue;
```

C++ comment

if (gdk_screen_is_composited(screen)) {

Move open brace to next line

Simon Steinbeiß @ochosi said:

I rebased and applied the patch on top of git master, but it doesn't work properly anymore. Obviously too much has changed in Xfwm4 for this to still work. Half of the time, the workspace-window doesn't show up (actually, it really seems pretty much exactly 50% of the time). I guess this needs more work.

Simon Steinbeiß @ochosi submitted a patch:

This is just a rebased version of the previously submitted patch with the changes suggested by Olivier. However, there seems to be some problem, the workspace window only shows up every second time you switch workspaces.

Patch 5904, "Rebased patch against git master":
0001-Add-popup-when-changing-workspaces.patch

Steve Dodier-Lazaro said:

There probably is a missing break; in line 391 of events.c.

The patch appears to need major reworking, currently the wsWin will be displayed only if no other wsWin is still being displayed (Simon, this is why it displays only one time out of two).

A possibly more proper way of doing this would be to keep a single wsWin object around, update its information accordingly for each workspace event and show/hide it when need be.

Olivier, do you have some more advice for whomever wants to fix this patch?

Yousuf Philips @philipzae said:

Someone in the video below mentioned this issue and I was just about to file a duplicate. https://youtu.be/Tcb2lLVBKBw?t=330

This bug is incorrectly set to NEEDINFO, when no info is needed from the bug report.

added 5. User Experience (UX) ~183 Patch labels

added 2. Feature label

As referenced in the video of my previous message, any type of notification of the switch would be a step in the right direction, even if it was a notification message, as presently, only if you have the workspace plugin can you know which workspace you are on.

Mate uses a workspace overlay similar to the alt+tab switcher to show where you are, with a mix of the workspace switcher of showing the squares the visible dialogs.

Image pulled from here https://youtu.be/F3Yxy_jH9Ak?t=425

mentioned in issue #85

I think this is important enough. Switching workspaces should be obvious and a little animation, like showing the workspace plugin and highlight the switched-top workspace, would do.

mentioned in issue xfdesktop#163 (closed)

Visual feed back when switching workspaces

Submitted by Matt

Description

Designs

Child items 0

Activity