No need to have that public, so we can please the compiler.

Adam Purkrt authored 7 years ago and Olivier Fourdan committed 7 years ago

Bug: 11960

This patch fixes the erratic behaviour when unmaximizing a window by
dragging it from the absolute top.

clientToggleMaximized is now called with each motion event if
a window is maximized, hence it is always unmaximized before possibly
toggling maximization again in clientTile further down.

When the xrandr layout is changed, we recompute the screen size on the
actual monitors size and layout.

Use this computed value instead of the size reported by Xlib as it's not
yet updated by the time we reconfigure our display. This is particularly
bad when the compositor is enabled as the overlay window end up being of
the wrong size.

David Siroky authored 7 years ago and Olivier Fourdan committed 7 years ago

Bug: 2701

Optionally raise the window being considered while cycling.

Bug: 13954

When a client issues a ConfigureRequest() on a toplevel window, that
window may transition from maximized to un-maximized state.

Make sure we repaint and relocate the client window within the frame.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

When using xpresent as vblank method, the clipping region would not
match the zoom level causing artifacts.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

vblank method can be selected using a command line option.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

When running xfwm4 from a nested X11 server (Xnest, Xephyr) from within
a Wayland session, GDK will selects in priority the Wayland backend,
which will lead to a crash because xfwm4 is an X11 window manager and
not a Wayland client.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Bug: 13954

Commit aee8b25a:

    Do not prevent ALT+Mouse resizing for borderless maximized windows.

Introduced a regression with windows using size increment (like most
terminal emulators).

Fix the size increment issue while preserving the possibility to resize
maximized window.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

Andrey Alekseenkov authored 7 years ago and Olivier Fourdan committed 7 years ago

Bug: 13964

Bug: 13970

Not that it matters much in this case though.

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>

P. Pronk authored 8 years ago and Olivier Fourdan committed 7 years ago

Bug: 13284

When dragging a window from a large monitor to the top of a smaller monitor to
maximize the window, it is possible that the window gets maximised on a
different monitor then the monitor your mouse is.

This happens because clientToggleMaximized uses the center point of the window
to calculate on which monitor the window should be maximised.

To fix this behaviour this commits adds a clientToggleMaximizedAtPoint method
so we can tell on which monitor the window should be maximised.

Xfwm error handler will cover all errors itself, there is no
necessity to use error traps for client.

GDK X error traps were changed in GDK 3 so using these traps
caused unwanted SIGTRAPs within GDK X error handler.

Bug: 13607

If XPresentPixmap() fails, we would disable Present rather that waiting
for a notification that will never arrive.

But that relies on the actual window to be reported in the XError, which
is not necessarily the case.

Disable Xpresent for all screens as we are not sure we can tell which
one from the resource id.

Błażej Szczygieł authored 7 years ago and Olivier Fourdan committed 7 years ago

Bug: 13613

Since commit 7115d1b4, we can't disable second (broken) vblank waiting
code.

glXSwapBuffers() already waits for v-blank (if enabled in driver), so
any other "synthetic" waiting for v-blank can reduce performance
(de-sync) without actual benefit.

This patch removes old code to prevent waiting for vblank twice.

Bug: 13608

Commit 58955779 (Use ximerama indices for _NET_WM_FULLSCREEN_MONITORS)
introduced a regression because the monitor index was wrongly compared
against the total number of monitors, which would falsely assume that
the Xrandr query failed whereas it actually worked.

Fix the false comparison and also use the screen size as fallback values
in case the Xrandr really failed so that we don't end up using random
uninitialized values.