Fix folder string being "(null)" in error popup in desktop settings

Ibrahim Burak Yorulmazrequested to merge
iburaky2/xfdesktop:fix/xfdesktop-settings-error-popup into master

When the desktop settings fails to enumerate over the folder with wallpapers for whatever reason (such as #444 ), the error message currently prints "(null)" instead of the actual selected folder path. This PR makes it use the actual selected folder path.

Before:

image.png

After:

image.png

Regarding why there is an error popup in the first place when the program quite clearly can enumerate over the files, in the case of #444 , there appears to be a race condition between cb_update_background_tab and the enumeration. We could return early from cb_update_background_tab from enumeration, forcing it to complete but I don't know if that is a good idea.

Merge request reports