Skip to content

Fix string leak in update_icon_view_model

correctmost requested to merge correctmost/xfdesktop:cm/fix-view-model-leak into master

Leak report

41 bytes in 1 blocks are definitely lost in loss record 15,178 of 35,485
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x546D661: g_malloc (gmem.c:100)
   by 0x5486DD3: g_strdup (gstrfuncs.c:323)
   by 0x5589AA5: g_strdup_inline (gstrfuncs.h:321)
   by 0x5589AA5: g_value_dup_string (gvaluetypes.c:1159)
   by 0x573E9BB: xfconf_channel_get_string (xfconf-channel.c:794)
   by 0x115112: xfdesktop_settings_get_backdrop_image (xfdesktop-background-settings.c:774)
   by 0x11543F: update_icon_view_model (xfdesktop-background-settings.c:953)
   by 0x115E37: xfdesktop_settings_update_iconview_folder (xfdesktop-background-settings.c:1096)
   by 0x11656D: last_image_changed (xfdesktop-background-settings.c:1110)
[...snip...]

Testing

  • No issues were detected when testing the patch with Valgrind

Merge request reports