Skip to content

Fix GFile leak in backdrop cycler

correctmost requested to merge correctmost/xfdesktop:cm/fix-cycler-leak into master

Leak report

82 (32 direct, 50 indirect) bytes in 1 blocks are definitely lost in loss record 10,453 of 14,616
   at 0x484BC13: calloc (vg_replace_malloc.c:1675)
   by 0x4A846B5: g_malloc0 (gmem.c:133)
   by 0x4B98421: g_type_create_instance (gtype.c:1933)
   by 0x4B7AF87: g_object_new_internal (gobject.c:2606)
   by 0x4B7C82D: g_object_new_with_properties (gobject.c:2769)
   by 0x4B7D66E: g_object_new (gobject.c:2415)
   by 0x498A416: _g_local_file_new (glocalfile.c:233)
   by 0x4993C4D: g_local_vfs_get_file_for_path (glocalvfs.c:88)
   by 0x491B252: g_vfs_get_file_for_path (gvfs.c:165)
   by 0x8943095: g_daemon_vfs_get_file_for_path (gdaemonvfs.c:383)
   by 0x491B252: g_vfs_get_file_for_path (gvfs.c:165)
   by 0x48C56EE: g_file_new_for_path (gfile.c:7198)
   by 0x1324A1: xfdesktop_backdrop_cycler_set_image_filename (xfdesktop-backdrop-cycler.c:918)
   by 0x132712: xfdesktop_backdrop_cycler_set_property (xfdesktop-backdrop-cycler.c:239)
   by 0x4B79596: object_set_property (gobject.c:2172)
   by 0x4B7B095: g_object_new_internal (gobject.c:2651)
   by 0x4B7CE9C: g_object_new_valist (gobject.c:2945)
   by 0x4B7D64B: g_object_new (gobject.c:2418)
   by 0x13178D: xfdesktop_backdrop_cycler_new (xfdesktop-backdrop-cycler.c:1158)
[...snip...]

Testing

  • No issues were detected when testing the patch with Valgrind

Merge request reports