Skip to content

Fix GFileInfo leak in xfdesktop_special_file_icon_new

correctmost requested to merge correctmost/xfdesktop:cm/fix-fileinfo-leak into master

Leak report

214 (40 direct, 174 indirect) bytes in 1 blocks are definitely lost in loss record 14,314 of 15,562
   at 0x484BC13: calloc (vg_replace_malloc.c:1675)
   by 0x4A846B5: g_malloc0 (gmem.c:133)
   by 0x4B98421: g_type_create_instance (gtype.c:1933)
   by 0x4B7AF87: g_object_new_internal (gobject.c:2606)
   by 0x4B7C82D: g_object_new_with_properties (gobject.c:2769)
   by 0x4B7D66E: g_object_new (gobject.c:2415)
   by 0x48CBE72: g_file_info_new (gfileinfo.c:390)
   by 0x8984BAD: _g_dbus_get_file_info (gvfsdaemonprotocol.c:335)
   by 0x8939021: g_daemon_file_query_filesystem_info (gdaemonfile.c:2051)
   by 0x48BF0D9: g_file_query_filesystem_info (gfile.c:1485)
   by 0x15E73D: xfdesktop_special_file_icon_new (xfdesktop-special-file-icon.c:521)
   by 0x1514F2: add_special_file_icon (xfdesktop-file-icon-model.c:610)
   by 0x1514F2: xfdesktop_file_icon_model_reload (xfdesktop-file-icon-model.c:1201)
   by 0x14DBB1: xfdesktop_file_icon_manager_constructed (xfdesktop-file-icon-manager.c:545)
[...snip...]

Testing

  • No issues were detected when testing the patch with Valgrind

Merge request reports