Skip to content

Fix leaks in xfdesktop_file_utils_next_new_file_name

correctmost requested to merge correctmost/xfdesktop:cm/fix-new-filename-leaks into master

Leak report

48 (32 direct, 16 indirect) bytes in 1 blocks are definitely lost in loss record 8,947 of 15,550
   at 0x484BC13: calloc (vg_replace_malloc.c:1675)
   by 0x4A846B5: g_malloc0 (gmem.c:133)
   by 0x4B98421: g_type_create_instance (gtype.c:1933)
   by 0x4B7AF87: g_object_new_internal (gobject.c:2606)
   by 0x4B7C82D: g_object_new_with_properties (gobject.c:2769)
   by 0x4B7D66E: g_object_new (gobject.c:2415)
   by 0x498A416: _g_local_file_new (glocalfile.c:233)
   by 0x498A4C4: g_local_file_get_parent (glocalfile.c:447)
   by 0x48BE1E8: g_file_get_parent (gfile.c:838)
   by 0x153F9F: xfdesktop_file_utils_next_new_file_name (xfdesktop-file-utils.c:309)
   by 0x1559FC: xfdesktop_file_utils_prompt_for_new_folder_name (xfdesktop-file-utils.c:1291)
   by 0x149FD1: xfdesktop_file_icon_manager_create_folder (xfdesktop-file-icon-manager.c:1114)
   by 0x14A07D: xfdesktop_file_icon_menu_create_folder (xfdesktop-file-icon-manager.c:1135)
[...snip...]

11 bytes in 1 blocks are definitely lost in loss record 879 of 15,513
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x4A84661: g_malloc (gmem.c:100)
   by 0x4A694FC: g_path_get_basename (gfileutils.c:2636)
   by 0x4987B70: g_local_file_get_basename (glocalfile.c:293)
   by 0x48BDD86: g_file_get_basename (gfile.c:567)
   by 0x153F8B: xfdesktop_file_utils_next_new_file_name (xfdesktop-file-utils.c:310)
   by 0x1559CC: xfdesktop_file_utils_prompt_for_new_folder_name (xfdesktop-file-utils.c:1289)
   by 0x149FB1: xfdesktop_file_icon_manager_create_folder (xfdesktop-file-icon-manager.c:1114)
   by 0x14A05D: xfdesktop_file_icon_menu_create_folder (xfdesktop-file-icon-manager.c:1135)
[...snip...]

13 bytes in 1 blocks are definitely lost in loss record 963 of 15,513
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x59E5438: __vasprintf_internal (vasprintf.c:116)
   by 0x4AD027E: g_vasprintf (gprintf.c:341)
   by 0x4A9DF9E: g_strdup_vprintf (gstrfuncs.c:511)
   by 0x4A9E055: g_strdup_printf (gstrfuncs.c:541)
   by 0x15403B: xfdesktop_file_utils_next_new_file_name (xfdesktop-file-utils.c:332)
   by 0x1559CC: xfdesktop_file_utils_prompt_for_new_folder_name (xfdesktop-file-utils.c:1289)
   by 0x149FB1: xfdesktop_file_icon_manager_create_folder (xfdesktop-file-icon-manager.c:1114)
   by 0x14A05D: xfdesktop_file_icon_menu_create_folder (xfdesktop-file-icon-manager.c:1135)
[...snip...]

Testing

  • No issues were detected when testing the patch with Valgrind

Merge request reports