Skip to content

Fix string leak in save_icons

correctmost requested to merge correctmost/xfdesktop:cm/fix-filename-leak into master

Leak report

53 bytes in 1 blocks are definitely lost in loss record 9,981 of 17,554
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x4A84661: g_malloc (gmem.c:100)
   by 0x4A9E111: g_strconcat (gstrfuncs.c:585)
   by 0x15779E: save_icons (xfdesktop-icon-position-configs.c:259)
   by 0x15936E: save_icons_idled (xfdesktop-icon-position-configs.c:508)
   by 0x4A7EDE2: g_timeout_dispatch (gmain.c:5070)
   by 0x4A7B7BB: g_main_dispatch (gmain.c:3357)
   by 0x4A7E190: g_main_context_dispatch_unlocked (gmain.c:4208)
   by 0x4A7E190: g_main_context_iterate_unlocked (gmain.c:4273)
   by 0x4A7E75D: g_main_context_iteration (gmain.c:4338)
   by 0x49364EF: g_application_run (gapplication.c:2715)
   by 0x12C6A7: main (main.c:64)

Testing

  • No issues were detected with Valgrind when testing the patch

Merge request reports