Skip to content

Fix string leak in set_accountsservice_user_bg

correctmost requested to merge correctmost/xfdesktop:cm/fix-user-bg-leak into master

Leak report

35 bytes in 1 blocks are definitely lost in loss record 6,529 of 13,829
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x4A84661: g_malloc (gmem.c:100)
   by 0x4A9DDD3: g_strdup (gstrfuncs.c:323)
   by 0x4ABF9E4: g_strdup_inline (gstrfuncs.h:321)
   by 0x4ABF9E4: g_variant_dup_string (gvariant.c:1547)
   by 0x4AC3CA7: g_variant_valist_get_nnp (gvariant.c:4974)
   by 0x4AC3CA7: g_variant_valist_get_leaf (gvariant.c:5144)
   by 0x4AC3CA7: g_variant_valist_get (gvariant.c:5325)
   by 0x4AC4006: g_variant_valist_get (gvariant.c:5360)
   by 0x4AC4B0F: g_variant_get_va (gvariant.c:5588)
   by 0x4AC4D87: g_variant_get (gvariant.c:5535)
   by 0x12E355: set_accountsservice_user_bg (xfce-desktop.c:247)
   by 0x12E355: backdrop_loaded (xfce-desktop.c:327)
   by 0x13374F: notify_complete (xfdesktop-backdrop-manager.c:740)
   by 0x134F69: xfdesktop_backdrop_manager_get_image_surface (xfdesktop-backdrop-manager.c:974)
   by 0x12E12E: fetch_backdrop (xfce-desktop.c:344)
   by 0x12E5BF: monitor_prop_changed (xfce-desktop.c:361)
[...snip...]

Testing

  • No issues were detected with Valgrind when testing the patch

Merge request reports