Desktop icon for Android phone no longer shows up in 4.20

Issue Description

After upgrading from Xfce 4.18 to 4.20, I no longer get a desktop icon for my Android phone when I plug it in. (Thunar does show the device in its sidebar.)

I can get an icon to appear by applying this patch, but I'm not sure if it's the correct fix:

diff --git a/src/xfdesktop-file-icon-model-filter.c b/src/xfdesktop-file-icon-model-filter.c
index 578d184a..ac15b8eb 100644
--- a/src/xfdesktop-file-icon-model-filter.c
+++ b/src/xfdesktop-file-icon-model-filter.c
@@ -421,7 +421,7 @@ is_volume_visible(XfdesktopFileIconModelFilter *filter, XfdesktopVolumeIcon *ico
             visible = (filter->show_network_volumes && g_strcmp0(volume_type, "network") == 0)
                 || (filter->show_device_volumes && is_removable && is_device)
                 || (filter->show_fixed_device_volumes && !is_removable && is_device)
-                || (filter->show_unknown_volumes && is_removable && volume_type == NULL);
+                || (filter->show_unknown_volumes && volume_type == NULL);
             g_free(volume_type);
         } else {
             GMount *mount = xfdesktop_volume_icon_peek_mount(icon);

Steps to Reproduce Issue

1. Open Desktop settings > File/Launcher Icons
2. Ensure that all of the Devices checkboxes are checked ("Network Shares", "Removable Disks and Drives", "Fixed Disks and Drives", "Other Devices")
3. Plug in an Android phone

--> Notice that a desktop icon for the phone is not shown

Expected Behavior

With 4.18, a desktop icon was shown when a device was in charging mode or transfer (mtp) mode.

Additional Information

Here's a screenshot from 4.18:

I can reproduce the issue with multiple Android phones.

Environment & Versions

• OS distribution and version: Arch Linux
• Overall Xfce version: 4.20
• xfdesktop version (git hash if not a release): 4.20.0 + master (4d10b9d7)
• Windowing system (X11/Wayland): X11
• Compositor and version (if Wayland): N/A
• GTK Theme: Adwaita
• Icon Theme: elementary
• UI Scale Factor: 1x

I also am experiencing this issue with a Pixel device since 4.20, looking at the proposed fix seems to align to the original code it was ported from in logic conditions (in that, "is_removable" was not in the original boolean):

Commit: 09ceb320

gboolean visible = (g_strcmp0(volume_type, "network") == 0 && fmanager->show_network_volumes)
    || (g_strcmp0(volume_type, "device") == 0 && fmanager->show_device_volumes)
    || (volume_type == NULL && fmanager->show_unknown_volumes);

It was then changed a few commits later to insert is_removable as a clause over in this commit: dff3de49

Per the comment "Some of it was still in the 'loader' model, and I'd rather that model just hold everything and delegate all visibility decisions to the filter." @kelnos had a plan of attack but something went sideways in regards to Android devices, presumably because modern Pixels are not removable SD cards anymore...

closed with commit 36398771

Brian Tarricone closed with commit 36398771 5 hours ago

Thank you!