Skip to content

Desktop icon for Android phone no longer shows up in 4.20

Issue Description

After upgrading from Xfce 4.18 to 4.20, I no longer get a desktop icon for my Android phone when I plug it in. (Thunar does show the device in its sidebar.)

I can get an icon to appear by applying this patch, but I'm not sure if it's the correct fix:

diff --git a/src/xfdesktop-file-icon-model-filter.c b/src/xfdesktop-file-icon-model-filter.c
index 578d184a..ac15b8eb 100644
--- a/src/xfdesktop-file-icon-model-filter.c
+++ b/src/xfdesktop-file-icon-model-filter.c
@@ -421,7 +421,7 @@ is_volume_visible(XfdesktopFileIconModelFilter *filter, XfdesktopVolumeIcon *ico
             visible = (filter->show_network_volumes && g_strcmp0(volume_type, "network") == 0)
                 || (filter->show_device_volumes && is_removable && is_device)
                 || (filter->show_fixed_device_volumes && !is_removable && is_device)
-                || (filter->show_unknown_volumes && is_removable && volume_type == NULL);
+                || (filter->show_unknown_volumes && volume_type == NULL);
             g_free(volume_type);
         } else {
             GMount *mount = xfdesktop_volume_icon_peek_mount(icon);

Steps to Reproduce Issue

  1. Open Desktop settings > File/Launcher Icons
  2. Ensure that all of the Devices checkboxes are checked ("Network Shares", "Removable Disks and Drives", "Fixed Disks and Drives", "Other Devices")
  3. Plug in an Android phone

--> Notice that a desktop icon for the phone is not shown

Expected Behavior

With 4.18, a desktop icon was shown when a device was in charging mode or transfer (mtp) mode.

Additional Information

Here's a screenshot from 4.18:

418_android

I can reproduce the issue with multiple Android phones.

Environment & Versions

  • OS distribution and version: Arch Linux
  • Overall Xfce version: 4.20
  • xfdesktop version (git hash if not a release): 4.20.0 + master (4d10b9d7)
  • Windowing system (X11/Wayland): X11
  • Compositor and version (if Wayland): N/A
  • GTK Theme: Adwaita
  • Icon Theme: elementary
  • UI Scale Factor: 1x