Skip to content

cache: Fix overwritten error

Gaël Bonithon requested to merge Tamaranch/xfconf:fix-overwritten-error into master

Obviously, it's the day I release 4.18.2 that I find a warning 😕 Fortunately, it's nothing we can't live with.

It happens when you try to set a property that doesn't exist yet, without having queried it first, so that it hasn't been cached:

GLib-WARNING **: 17:52:37.372: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: Property "/show-sidebar" does not exist on channel "catfish"

@kelnos I don't know if you want to do something more sophisticated instead of dbus_error_name != NULL. Perhaps one should do a g_error_matches()...

Feel free to modify whatever you like, or close this MR and open your own if you prefer :)

Merge request reports