Skip to content

display-settings: Fix string leak when deleting profile

correctmostrequested to merge
correctmost/xfce4-settings:cm/fix-delete-leak into master

Leak report

Direct leak of 37 byte(s) in 1 object(s) allocated from:
    #0 0x7f1cb3d72fc5 in malloc
    #1 0x7f1cb39991a2 in g_malloc glib/glib/gmem.c:100:13
    #2 0x7f1cb3a16a94 in g_strdup glib/glib/gstrfuncs.c:323:17
    #3 0x7f1cb09c2dd2 in g_strdup_inline glib/glib/gstrfuncs.h:321:10
    #4 0x7f1cb09c2dd2 in value_lcopy_string glib/gobject/gvaluetypes.c:316:17
    #5 0x7f1cb3083156 in gtk_tree_model_get_valist gtk/gtk/gtktreemodel.c:1812:7
    #6 0x7f1cb308279e in gtk_tree_model_get gtk/gtk/gtktreemodel.c:1774:3
    #7 0x5622aee5f41f in display_settings_profile_delete xfce4-settings/dialogs/display-settings/main.c:1610:9
[...snip...]

Testing

  • No issues were detected when testing the patch with UBSan, LSan, and ASan

Merge request reports