Skip to content

xfsettingsd: Fix GVariant leak

correctmost requested to merge correctmost/xfce4-settings:cm/fix-gvariant-leak into master

Leak report

Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x64889cfc3be9 in malloc (/usr/asan/bin/xfsettingsd+0x204be9)
    #1 0x787af6bd5062 in g_malloc glib/gmem.c:100:13
    #2 0x787af6c6a0b4 in g_variant_alloc glib/gvariant-core.c:560:11
    #3 0x787af6c6a0b4 in g_variant_new_from_children glib/gvariant-core.c:711:11
    #4 0x787af6c62401 in g_variant_builder_end glib/gvariant.c:3777:11
    #5 0x787af71a55e2 in parse_value_from_blob gio/gdbusmessage.c:2125:21
    #6 0x787af71a4265 in g_dbus_message_new_from_blob gio/gdbusmessage.c:2497:27
    #7 0x787af71c090d in _g_dbus_worker_do_read_cb gio/gdbusprivate.c:752:21
    #8 0x787af70e20db in g_task_return_now gio/gtask.c:1361:7
    #9 0x787af70e20db in complete_in_idle_cb gio/gtask.c:1375:3
    #10 0x787af6bc1102 in g_main_dispatch glib/gmain.c:3357:27
    #11 0x787af6bc1102 in g_main_context_dispatch_unlocked glib/gmain.c:4208:7
    #12 0x787af6bc1dcf in g_main_context_iterate_unlocked glib/gmain.c:4273:5
    #13 0x787af6bc2637 in g_main_loop_run glib/gmain.c:4475:5
    #14 0x787af71bfb46 in gdbus_shared_thread_func gio/gdbusprivate.c:284:3
    #15 0x787af6c29f07 in g_thread_proxy glib/gthread.c:892:20
    #16 0x64889cf0009d in asan_thread_start(void*) (/usr/asan/bin/xfsettingsd+0x14109d)

Steps to reproduce

  • xfsettingsd --display :0.0 --sm-client-id 29006facd-4747-459b-9b0a-4692daf18369

Testing

  • No issues were detected with LSan, ASan, or Valgrind when testing the patch

Merge request reports