Skip to content

mouse: Fix XGetExtensionVersion leaks

correctmost requested to merge correctmost/xfce4-settings:cm/fix-mouse-leaks into master

Leak reports

Direct leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0x5eef408c81f9 in malloc (/usr/asan/bin/xfce4-mouse-settings+0x1761f9)
    #1 0x77a0b738e4ac in _XiGetExtensionVersionRequest /usr/src/debug/libxi/libXi-1.8.2/src/XGetVers.c:101:33
    #2 0x77a0b7394df4 in XGetExtensionVersion /usr/src/debug/libxi/libXi-1.8.2/src/XGetVers.c:75:11
    #3 0x5eef4091136a in main xfce4-settings/dialogs/mouse-settings/main.c:2239:15
    #4 0x77a0b5756e07 in __libc_start_call_main /usr/src/debug/glibc/glibc/csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #5 0x77a0b5756ecb in __libc_start_main /usr/src/debug/glibc/glibc/csu/../csu/libc-start.c:360:3
    #6 0x5eef407dc114 in _start (/usr/asan/bin/xfce4-mouse-settings+0x8a114) (BuildId: 9c53b44fd8d72c0a)

8 bytes in 1 blocks are definitely lost in loss record 398 of 7,181
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x48CD4AC: _XiGetExtensionVersionRequest (XGetVers.c:101)
   by 0x48D3DF4: XGetExtensionVersion (XGetVers.c:75)
   by 0x11EEA4: xfce_pointers_helper_init (pointers.c:136)
   by 0x565F848: g_type_create_instance (gtype.c:1951)
   by 0x5644684: g_object_new_internal.part.0 (gobject.c:2606)
   by 0x5645CFE: UnknownInlinedFun (gobject.c:2603)
   by 0x5645CFE: g_object_new_with_properties (gobject.c:2769)
   by 0x5646D51: g_object_new (gobject.c:2415)
   by 0x1189F5: on_name_acquired (main.c:128)
   by 0x5559BEC: UnknownInlinedFun (gdbusnameowning.c:153)
   by 0x5559BEC: do_call.lto_priv.0 (gdbusnameowning.c:205)
   by 0x5559E19: UnknownInlinedFun (gdbusnameowning.c:219)
   by 0x5559E19: UnknownInlinedFun (gdbusnameowning.c:210)
   by 0x5559E19: UnknownInlinedFun (gdbusnameowning.c:286)
   by 0x5559E19: on_name_lost_or_acquired (gdbusnameowning.c:250)
   by 0x5551A38: emit_signal_instance_in_idle_cb (gdbusconnection.c:4189)
   by 0x56DD298: g_main_dispatch.lto_priv.0 (gmain.c:3344)
   by 0x573FEC6: UnknownInlinedFun (gmain.c:4152)
   by 0x573FEC6: g_main_context_iterate_unlocked.isra.0 (gmain.c:4217)
   by 0x56DDFA6: g_main_loop_run (gmain.c:4419)
   by 0x4BFFEA5: gtk_main (gtkmain.c:1329)
   by 0x1194A0: main (main.c:361)

Steps to reproduce

  • Open the Mouse and Touchpad settings in xfce4-settings-manager

Testing

  • No issues were detected with LSan, ASan, or Valgrind when testing the patch

Merge request reports