Skip to content

mime: Fix UMRs with GdkEvent

correctmost requested to merge correctmost/xfce4-settings:cm/fix-umr into master

Valgrind report

2 errors in context 1 of 37:
Conditional jump or move depends on uninitialised value(s)
   at 0x4AD1735: gtk_gesture_filter_event (gtkgesture.c:727)
   by 0x4A7AEC5: gtk_event_controller_handle_event (gtkeventcontroller.c:224)
   by 0x4D3ECEB: _gtk_widget_run_controllers (gtkwidget.c:7447)
   by 0x4D3E535: gtk_widget_real_button_event (gtkwidget.c:7208)
   by 0x491638C: _gtk_marshal_BOOLEAN__BOXEDv (gtkmarshalers.c:130)
   by 0x57BEB61: UnknownInlinedFun (gclosure.c:897)
   by 0x57BEB61: signal_emit_valist_unlocked (gsignal.c:3424)
   by 0x57BEF51: g_signal_emit_by_name (gsignal.c:3624)
   by 0x117D46: xfce_mime_helper_chooser_pressed (xfce-mime-helper-chooser.c:774)
[...snip...]

2 errors in context 2 of 37:
Conditional jump or move depends on uninitialised value(s)
   at 0x4AD172A: gtk_gesture_filter_event (gtkgesture.c:727)
   by 0x4A7AEC5: gtk_event_controller_handle_event (gtkeventcontroller.c:224)
   by 0x4D3ECEB: _gtk_widget_run_controllers (gtkwidget.c:7447)
   by 0x4D3E535: gtk_widget_real_button_event (gtkwidget.c:7208)
   by 0x491638C: _gtk_marshal_BOOLEAN__BOXEDv (gtkmarshalers.c:130)
   by 0x57BEB61: UnknownInlinedFun (gclosure.c:897)
   by 0x57BEB61: signal_emit_valist_unlocked (gsignal.c:3424)
   by 0x57BEF51: g_signal_emit_by_name (gsignal.c:3624)
   by 0x117D46: xfce_mime_helper_chooser_pressed (xfce-mime-helper-chooser.c:774)
[...snip...]

2 errors in context 3 of 37:
Conditional jump or move depends on uninitialised value(s)
   at 0x4D3EC5C: _gtk_widget_run_controllers (gtkwidget.c:7430)
   by 0x4D3E535: gtk_widget_real_button_event (gtkwidget.c:7208)
   by 0x491638C: _gtk_marshal_BOOLEAN__BOXEDv (gtkmarshalers.c:130)
   by 0x57BEB61: UnknownInlinedFun (gclosure.c:897)
   by 0x57BEB61: signal_emit_valist_unlocked (gsignal.c:3424)
   by 0x57BEF51: g_signal_emit_by_name (gsignal.c:3624)
   by 0x117D46: xfce_mime_helper_chooser_pressed (xfce-mime-helper-chooser.c:774)
[...snip...]

Steps to reproduce

  • Select a new default web browser on the Internet tab

Testing

  • No issues were detected with LSan, ASan, or Valgrind when testing the patch

Merge request reports