Skip to content

mime: Fix leak in xfce_mime_window_row_activated

correctmost requested to merge correctmost/xfce4-settings:cm/fix-mime-type-leak into master

Leak report

Direct leak of 17 byte(s) in 1 object(s) allocated from:
    #0 0x62e6bf6a51e9 in malloc (/usr/asan/bin/xfce4-mime-settings+0x17a1e9) (BuildId: b9b947ff039756fa)
    #1 0x7324ca662e4a in g_malloc /usr/src/debug/glib2/build/../glib/glib/gmem.c:100:13
    #2 0x7324ca67925a in g_strdup /usr/src/debug/glib2/build/../glib/glib/gstrfuncs.c:323:17
    #3 0x7324ca7873ac in g_strdup_inline /usr/src/debug/glib2/build/../glib/glib/gstrfuncs.h:321:10
    #4 0x7324ca7873ac in value_lcopy_string /usr/src/debug/glib2/build/../glib/gobject/gvaluetypes.c:315:17
    #5 0x7324cbb533f6 in gtk_tree_model_get_valist gtk/gtktreemodel.c:1812:7
    #6 0x7324cbb52a3e in gtk_tree_model_get gtk/gtktreemodel.c:1774:3
    #7 0x62e6bf70ba27 in xfce_mime_window_row_activated xfce4-settings/dialogs/mime-settings/xfce-mime-window.c:902:7
    #8 0x62e6bf70acd1 in xfce_mime_window_set_application_cb xfce4-settings/dialogs/mime-settings/xfce-mime-window.c:701:3
    #9 0x7324ca781b61 in _g_closure_invoke_va /usr/src/debug/glib2/build/../glib/gobject/gclosure.c:897:7
    #10 0x7324ca781b61 in signal_emit_valist_unlocked /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3424:8
[...snip...]

Testing

  • No issues were detected with LSan, ASan, or Valgrind when testing the patch

Merge request reports