Skip to content

mime: Fix GList leak in xfce_mime_helper_chooser_pressed

correctmost requested to merge correctmost/xfce4-settings:cm/fix-glist-leak into master

Leak report

Indirect leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x5b7d40ab11e9 in malloc (/usr/asan/bin/xfce4-mime-settings+0x17a1e9) (BuildId: 7d0b8dc626730f20)
    #1 0x705bf94e6e4a in g_malloc /usr/src/debug/glib2/build/../glib/glib/gmem.c:100:13
    #2 0x705bf94dd452 in g_list_insert_sorted_real /usr/src/debug/glib2/build/../glib/glib/glist.c:1041:14
    #3 0x5b7d40b01d25 in xfce_mime_helper_database_get_all xfce4-settings/dialogs/mime-settings/xfce-mime-helper.c:1142:19
    #4 0x5b7d40b09687 in xfce_mime_helper_chooser_pressed xfce4-settings/dialogs/mime-settings/xfce-mime-helper-chooser.c:707:13
    #5 0x705bf95e4699 in g_closure_invoke /usr/src/debug/glib2/build/../glib/gobject/gclosure.c:834:7
    #6 0x705bf96152a4 in signal_emit_unlocked_R.isra.0 /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3888:8
    #7 0x705bf9605a0b in signal_emit_valist_unlocked /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3520:7
    #8 0x705bf9605c71 in g_signal_emit_valist /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3263:7
    #9 0x705bf9605d33 in g_signal_emit /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3583:3
    #10 0x705bfa466703 in multipress_pressed_cb gtk/gtkbutton.c:651:3
[...snip...]

Testing

  • No issues were detected with LSan, ASan, or Valgrind when testing the patch

Merge request reports