Skip to content

Fix leaks in xfsm_properties_load

correctmost requested to merge correctmost/xfce4-session:cm/fix-properties-leaks into master

Leak report

228 bytes in 6 blocks are definitely lost in loss record 9,645 of 10,517
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x5751661: g_malloc (gmem.c:100)
   by 0x5741EC4: g_key_file_parse_value_as_string (gkeyfile.c:4310)
   by 0x57433D5: g_key_file_get_string (gkeyfile.c:1965)
   by 0x1301E0: xfsm_properties_load (xfsm-properties.c:260)
   by 0x12C985: xfsm_manager_load_session (xfsm-manager.c:537)
   by 0x12CB2B: xfsm_manager_load_settings (xfsm-manager.c:801)
   by 0x12CB2B: xfsm_manager_load (xfsm-manager.c:837)
[...snip...]

138 bytes in 6 blocks are definitely lost in loss record 9,377 of 10,517
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x5751661: g_malloc (gmem.c:100)
   by 0x5741EC4: g_key_file_parse_value_as_string (gkeyfile.c:4310)
   by 0x57433D5: g_key_file_get_string (gkeyfile.c:1965)
   by 0x13022C: xfsm_properties_load (xfsm-properties.c:270)
   by 0x12C985: xfsm_manager_load_session (xfsm-manager.c:537)
   by 0x12CB2B: xfsm_manager_load_settings (xfsm-manager.c:801)
   by 0x12CB2B: xfsm_manager_load (xfsm-manager.c:837)
[...snip...]

225 bytes in 19 blocks are definitely lost in loss record 9,644 of 10,517
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x5751661: g_malloc (gmem.c:100)
   by 0x5741EC4: g_key_file_parse_value_as_string (gkeyfile.c:4310)
   by 0x57433D5: g_key_file_get_string (gkeyfile.c:1965)
   by 0x130457: xfsm_properties_load (xfsm-properties.c:304)
   by 0x12C985: xfsm_manager_load_session (xfsm-manager.c:537)
   by 0x12CB2B: xfsm_manager_load_settings (xfsm-manager.c:801)
   by 0x12CB2B: xfsm_manager_load (xfsm-manager.c:837)
[...snip...]

Testing

  • No issues were detected when testing the patch with Valgrind

Merge request reports