Skip to content

manager: Fix leaks in xfsm_manager_load_failsafe

correctmost requested to merge correctmost/xfce4-session:cm/fix-failsafe-leaks into master

Leak report

18 bytes in 1 blocks are definitely lost in loss record 2,259 of 9,974
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x5751661: g_malloc (gmem.c:100)
   by 0x576ADD3: g_strdup (gstrfuncs.c:323)
   by 0x48D58DC: g_strdup_inline (gstrfuncs.h:321)
   by 0x48D58DC: xfce_gethostname (xfce-miscutils.c:307)
   by 0x12A89F: xfsm_manager_load_failsafe (xfsm-manager.c:588)
   by 0x12CBB1: xfsm_manager_load_settings (xfsm-manager.c:810)
   by 0x12CBB1: xfsm_manager_load (xfsm-manager.c:835)
[...snip...]

144 (88 direct, 56 indirect) bytes in 5 blocks are definitely lost in loss record 8,895 of 9,974
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x5751661: g_malloc (gmem.c:100)
   by 0x57517DC: g_malloc_n (gmem.c:410)
   by 0x576C558: g_strdupv (gstrfuncs.c:2612)
   by 0x12AB45: xfsm_manager_load_failsafe (xfsm-manager.c:643)
   by 0x12CBB1: xfsm_manager_load_settings (xfsm-manager.c:810)
   by 0x12CBB1: xfsm_manager_load (xfsm-manager.c:835)
[...snip...]

Testing

  • No issues were detected when testing the patch with Valgrind

Merge request reports