Alt + F4 open multiple windows when held

Submitted by Ricardo Biehl Pasquali

Assigned to Xfce Bug Triage

In a recent post on Xfce4-dev mailing list I've commented an issue about the 'xfsm-logout-dialog' https://mail.xfce.org/pipermail/xfce4-dev/2016-July/031701.html.

Basically, when you press and hold Alt + F4 (or your close window key) the save_yourself requests done initially from xfce_sm_client_request_shutdown() https://github.com/xfce-mirror/xfwm4/blob/5effde6f2f12f8bbd895dbac14d7eb19dd897c7f/src/events.c#L491 and handled by the session manager https://github.com/xfce-mirror/xfce4-session/blob/ac387875a5e0d4239848fa3560757fb7ef0c2338/xfce4-session/sm-layer.c#L253 begin growing according with key repeat speed and aren't dropped. It results in many logout dialog windows waiting to be executed while there is already one dialog executing.

Other thing I saw in the code is here https://github.com/xfce-mirror/xfce4-session/blob/2f07bb790b86ce83603d70162f7730ccdc81220b/xfce4-session/xfsm-logout-dialog.c#L767. Is the keyboard grabbing necessary? For example: you can't see the logout dialog until you release Alt + F4 key because the dialog is continuously trying to grab the key being that it ungrab it shortly.

Cheers!

Version: Unspecified