Add an option to pass --enable-ssh-support to gpg-agent
Submitted by Skunnyk
Assigned to Xfce Bug Triage
Description
Since http://git.xfce.org/xfce/xfce4-session/commit/?id=7892794fbf029a3b15d9e1320cf701bf0d31fd83 , gpg-agent is launched without the --enable-ssh-support option, unlike previous versions.
So I need to launch a xfconf-query to restore the previous behavior :
xfconf-query --create -c xfce4-session -p /startup/ssh-agent/type -t string -s gpg-agent
It would be cool to add a option to set it, for example in the Advanced tab in xfce4-session-settings, or document it :)
Version: Unspecified
Activity
The code portion isn't too hard but we'll need a decent UI for all the possible options. I added it to the design SIG since whatever I come up with will look terrible. https://wiki.xfce.org/design/xfce4-session/gpg-ssh-agents Once there's an accepted mockup I'll happily get to work on implementing it!
-
(In reply to Yves-Alexis Perez from comment 3)
Why not just adding enable-ssh-support to .gnupg/gpg-agent.conf?
Are you talking to me ? (© :p)
If yes, the answer is : simply because it does not work. I tried before finding this bug. I just re-tried, and :
$ grep enable .gnupg/gpg-agent.conf enable-ssh-support
(then restart the xfce session)
$ ps x | egrep 'ssh-agent|gpg-agent' 26852 ? Ss 0:00 /usr/bin/ssh-agent -s 26854 ? Ss 0:00 /usr/bin/gpg-agent --sh --daemon --write-env-file /home/fab/.cache/gpg-agent-info
-
(In reply to Fab from comment 4)
(In reply to Yves-Alexis Perez from comment 3)
Why not just adding enable-ssh-support to .gnupg/gpg-agent.conf?
Are you talking to me ? (© :p)
You and all people experiencing the problem.
If yes, the answer is : simply because it does not work. I tried before finding this bug. I just re-tried, and :
$ grep enable .gnupg/gpg-agent.conf enable-ssh-support
(then restart the xfce session)
$ ps x | egrep 'ssh-agent|gpg-agent' 26852 ? Ss 0:00 /usr/bin/ssh-agent -s 26854 ? Ss 0:00 /usr/bin/gpg-agent --sh --daemon --write-env-file /home/fab/.cache/gpg-agent-info
Well, gpg-agent.conf is a config file for gpg-agent, not for xfce4-session, so that's expected not to find the command line option. The whole point of the config file option is to not have to pass it on the command line. And it does work fine for me:
corsac 5806 0.0 0.0 238784 2252 ? Ss juil.03 0:03 gpg-agent --homedir /home/corsac/.gnupg --use-standard-socket --daemon
echo $SSH_AUTH_SOCK /home/corsac/.gnupg/S.gpg-agent.ssh
Note that you /might/ be a victim of bug #12044 where xfce4-session startup code will fail to check that gpg-agent is currently running and run a new one, but failing to setup properly the GPG_AGENT_INFO variable. This happens with gpg-agent 2.1+.
-
(In reply to Yves-Alexis Perez from comment 5)
Note that you /might/ be a victim of bug #12044 where xfce4-session startup code will fail to check that gpg-agent is currently running and run a new one, but failing to setup properly the GPG_AGENT_INFO variable. This happens with gpg-agent 2.1+.
I don't think so. I'm using gpg-agent from gnupg-2.0.26.
(In reply to Yves-Alexis Perez from comment 5)
Well, gpg-agent.conf is a config file for gpg-agent, not for xfce4-session, so that's expected not to find the command line option.
I'm aware of this, but in this case, I don't understand your comment 3. In my case, setting enable-ssh-support into .gnupg/gpg-agent.conf has no effect. Note that in the manual page of gpg-agent, it's not written that gpg-agent recognizes this option from the config file. As far I can see, it only recognizes the --enable-ssh-support command line option.
The whole point of the config file option is to not have to pass it on the command line. And it does work fine for me:
corsac 5806 0.0 0.0 238784 2252 ? Ss juil.03 0:03 gpg-agent --homedir /home/corsac/.gnupg --use-standard-socket --daemon
Many questions : how do you start gpg-agent ? Is this xfce4-session who started it ? If yes, how do you set theses CLI options ? Why do you set « --homedir /home/corsac/.gnupg » since AFAIK it is the default ?
On my system, the only way I found to enable gpg-agent ssh support since xfce 4.12 is to run the xfconf-query command provided by the OP.
-
(In reply to Yves-Alexis Perez from comment 5)
Well, gpg-agent.conf is a config file for gpg-agent, not for xfce4-session, so that's expected not to find the command line option. I'm aware of this, but in this case, I don't understand your comment 3. In my case, setting enable-ssh-support into .gnupg/gpg-agent.conf has no effect. Note that in the manual page of gpg-agent, it's not written that gpg-agent recognizes this option from the config file. As far I can see, it only recognizes the --enable-ssh-support command line option.
The whole point of the config file option is to not have to pass it on the command line. And it does work fine for me:
corsac 5806 0.0 0.0 238784 2252 ? Ss juil.03 0:03 gpg-agent --homedir /home/corsac/.gnupg --use-standard-socket --daemon
Many questions : how do you start gpg-agent ? Is this xfce4-session who started it ? If yes, how do you set theses CLI options ? Why do you set « --homedir /home/corsac/.gnupg » since AFAIK it is the default ?
On Debian, it's started by /etc/X11/Xsession.d/90gpg-agent, provided by the gpg-agent package. But here it might actually have been started by gpg itself.
added 5. CLI label
added 5. Settings label
added 2. Feature label
@skunnyk: did you want to move this forward?
added 5. GPG / SSH label
This feature is now documented in https://docs.xfce.org/xfce/xfce4-session/advanced#ssh_and_gpg_agents