Skip to content

xfpm-button: Fix XkbGetMap leak in xfpm_button_keysym_to_code_mask

Amends: f1203a44

Leak report

Direct leak of 72 byte(s) in 1 object(s) allocated from:
    #0 0x7a25b76fd1aa in calloc /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_malloc_linux.cpp:77
    #1 0x7a25af6c8e10 in XkbGetMap libx11/src/xkb/XKBGetMap.c:593
    #2 0x63a5cb1e1641 in xfpm_button_keysym_to_code_mask xfce4-power-manager/src/xfpm-button.c:127
    #3 0x63a5cb1e23d3 in xfpm_button_xevent_key xfce4-power-manager/src/xfpm-button.c:238
    #4 0x63a5cb1e3c41 in xfpm_button_setup xfce4-power-manager/src/xfpm-button.c:331
    #5 0x63a5cb1e3c41 in xfpm_button_init xfce4-power-manager/src/xfpm-button.c:371
    #6 0x7a25b0ded72a in g_type_create_instance ../gobject/gtype.c:1951
    #7 0x7a25b0d82fc7 in g_object_new_internal ../gobject/gobject.c:2606
    #8 0x7a25b0d87e2d in g_object_new_with_properties ../gobject/gobject.c:2769
    #9 0x7a25b0d8a189 in g_object_new ../gobject/gobject.c:2415
    #10 0x63a5cb1e5328 in xfpm_button_new xfce4-power-manager/src/xfpm-button.c:392
    #11 0x63a5cb1bcb50 in xfpm_manager_init xfce4-power-manager/src/xfpm-manager.c:666
[...snip...]

Testing

  • No issues were detected when testing the patch with UBSan, LSan, and ASan

Docs

Merge request reports

Loading