Skip to content

systray: Fix GSList element leak

correctmost requested to merge correctmost/xfce4-panel:cm/fix-gslist-leak into master

Leak report

16 bytes in 1 blocks are definitely lost in loss record 1,532 of 6,870
   at 0x48447A8: malloc (vg_replace_malloc.c:446)
   by 0x5441661: g_malloc (gmem.c:100)
   by 0x54597DB: g_slice_alloc (gslice.c:193)
   by 0x5459AF9: g_slist_insert_sorted_real (gslist.c:856)
   by 0x545A2DA: g_slist_insert_sorted_with_data (gslist.c:938)
   by 0x70DD8B1: systray_box_add (systray-box.c:643)
   by 0x539BFB6: g_cclosure_marshal_VOID__OBJECTv (gmarshal.c:1910)
   by 0x5397462: g_type_class_meta_marshalv (gclosure.c:1061)
   by 0x5398F21: _g_closure_invoke_va (gclosure.c:896)
   by 0x53AD82B: signal_emit_valist_unlocked (gsignal.c:3423)
   by 0x53B4C7A: g_signal_emit_valist (gsignal.c:3262)
   by 0x53B4D24: g_signal_emit (gsignal.c:3582)
   by 0x4A325F0: gtk_container_add (gtkcontainer.c:1877)
   by 0x70DBE58: systray_plugin_icon_added (systray.c:370)
[...snip...]

Testing

  • No issues were detected when testing the patch with Valgrind
  • I tested with nm-applet and then nm-applet + Pidgin and didn't notice any memory errors

Merge request reports