Systray legacy icons are drawn with offset

Systray legacy icons are drawn such as if distance from the left is doubled.

If systray is the leftmost element on the panel, it looks OK.

When I start adding separators (or any item) before systray, legacy icons are shifted to the right up to completely disappearing. Status notifiers are not affected.

xfce4-panel 4.20.3, X11, Arch Linux

I've done some investigation. Fixed it for myself, will create a merge request.

mentioned in merge request !168 (merged)

It's weird, I can't reproduce it. When I trace the values of alloc.x and box_alloc.x in !168 (merged) I always get 0 for both. What theme are you using? Do you have anything in ~/.config/gtk-3.0/gtk.css? Is there anything special in your panel and/or systray configuration that makes this reproducible?

added 5. Notification Area / Status Tray 5. X11 labels

added 3. Need Info label

~/.config/gtk-3.0/gtk.css — I have no such file.

Theme: Adwaita-dark

After update to 4.20 I switched to Wayland with labwc. I tried to set up scaling/fonts, then switched back to X11. Then I noticed this problem with tray icons. Not sure if I have anything special. I'll try to reproduce it using a new user account.

I think I've found what makes it reproduce. It's force-all-internal setting.

On a new account at first it didn't reproduce. Then I copied xfce4-panel.xml from my old account and it reproduced. I reduced the size of config came up with this minimal-ish XML (~/.config/xfce4/xfconf/xfce-perchannel-xml/xfce4-panel.xml)

<?xml version="1.1" encoding="UTF-8"?>

<channel name="xfce4-panel" version="1.0">
  <property name="force-all-internal" type="bool" value="true"/>
  <property name="panels" type="array">
    <value type="int" value="1"/>
    <property name="panel-1" type="empty">
      <property name="position" type="string" value="p=8;x=960;y=1066"/>
      <property name="length" type="uint" value="100"/>
      <property name="position-locked" type="bool" value="true"/>
      <property name="icon-size" type="uint" value="0"/>
      <property name="size" type="uint" value="32"/>
      <property name="plugin-ids" type="array">
        <value type="int" value="2"/>
        <value type="int" value="6"/>
      </property>
    </property>
  </property>
  <property name="plugins" type="empty">
    <property name="plugin-6" type="string" value="systray"/>
    <property name="plugin-2" type="string" value="showdesktop"/>
  </property>
  <property name="configver" type="int" value="2"/>
</channel>

With this config it reproduces. If I change force-all-internal to false, it does not reproduce.

Ah ok, which explains why it hadn't been noticed before. I think your patch is correct indeed, thank you.

removed 3. Need Info label

assigned to @yohanson

changed milestone to %4.21.0

closed with commit 3d21aa95

mentioned in commit 97b03edb

changed milestone to %4.20.4