Status Tray Plugin crashes in 14.16

Error shown in attached screenshot.

• I am not sure which process spins up the new 'Status Tray Plugin'. Please let me know where to look and I am happy to provide more information.
• This error only occurred after an update to 14.16.0, in which the old 'system notification' is replaced by 'Status Tray Plugin'.
• System is Arch Linux, up-to-date.
• This error is reproducible with teamviewer 15.13.6.
• Steps to reproduce:

1. Add the 'Status Tray Plugin' to the pannel
2. Start Teamviewer (installed from AUR - the arch user repository)

• As long as the Teamviewer main window is open, the error window will persist if you hit 'Execute'. I suppose as long as the main Teamviewer window is open, it tries to add an icon to the notification area, causing the crash.
• If you close the Teamviewer main window, and hit 'Execute' in the screenshot, then the Status Tray Plugin will start fine.

changed the description

changed title from Status Tray Plugin crashes to Status Tray Plugin crashes in 14.16

As I'm not a user of Arch, can you point me to the version of teamviewer you used?

added 5. Notification Area / Status Tray label

added 3. Need Info label

Teamviewer 15.13.6

https://aur.archlinux.org/packages/teamviewer/

I can reproduce on archlinux too by installing teamviewer:

(wrapper-2.0:1551594): GLib-CRITICAL **: 17:39:05.682: the GVariant format string '(a{sv})' has a type of '(a{sv})' but the given value has a type of '()'

(wrapper-2.0:1551594): GLib-CRITICAL **: 17:39:05.682: g_variant_get: assertion 'valid_format_string (format_string, TRUE, value)' failed

Ok, so at least I know now that this should be the StatusNotifierItem, not a systray item.

Could you do a really simple test and use the xfce4-statusnotifier-plugin instead of the statustray plugin to see if the crash happens there too? Just to make sure the problem didn't start to occur when merging the plugin into the panel code... Thanks!

I tried this and it shows exactly the same error.

Ok thanks! Well I think it's not hard to prevent the crash, but in my opinion TeamViewer is doing something wrong here...

Just wondering if you would suggest anything as a work-around for the time being?

According to this page the hplip-plugin also experiences a similar error.

https://aur.archlinux.org/packages/teamviewer/#comment-783179

I tried with teamviewer 15.13 on Ubuntu 20.04 (installed from https://www.teamviewer.com/download/linux/) and it worked fine for me - no crash of the panel whatsoever. So maybe this is a packaging error in Arch somehow?

I however tried to catch the error you reported in a branch - please test if you can. It's quite possible though that this doesn't fully catch the crash and that the crash simply happens later...

!26 (merged)

I confirm it fails with xfce4-statusnotifier-plugin 0.2.2 too, also with xfce4-panel 4.14.4, so not related to 4.16.

Maybe related to https://community.teamviewer.com/English/kb/articles/30653-system-tray-statusnotifier-and-teamviewer-for-linux (Last Updated: Dec 21, 2020)

!26 (merged) does not fix the issue on my side :/

I also think TeamViewer is at fault, but I'd still like to prevent the crash.

Does the error message change in any way after my patch?

I'm running Arch and noticed the systray crash with teamviewer when I updated to 4.16 (it did not crash for me with 4.14.4). I applied your patch and my systray no longer crashes when launching teamviewer (15.13.6). No teamviewer icon appears in the systray, but that's okay with me.

Weird, this does not fix the issue here, and I still have the same message as before :|

Silly me, it works when I run the good panel environment ;-)

(wrapper-2.0:153918): libsystray-WARNING **: 23:18:55.504: Could not parse properties for StatusNotifierItem.

No icon in systray, but no crash, so it can be an acceptable workaround.

Ok great!

Currently it should show a warning in the terminal, but I wonder whether you as users would expect more? (A popup dialog? An infobar in the plugin settings?)

Personally, I'm happy the way you have it. I wouldn't want anything popping up when I start teamviewer (unless it just happens once).

Same problem with Slackware-current after last upgrade two days ago. , i can't add Status Tray to my panel.

After a session loggedin i can see in my log

traps: xfce4-volumed[17194] trap int3 ip:7ff2e73fc157 sp:7fff56f40fd0 error:0 in libglib-2.0.so.0.6600.4[7ff2e73c1000+84000]

i found the issue after launch xfce4-panel with environnement var PANEL_DEBUG=1, it appears libdbusmenu-gtk3.so and libdbusmenu-glib.so.4 from package libdbusmenu are missing. all work after installing the new package libdbusmenu.

I seem to have both of these files. Messages in terminal when the fault occurs:

(wrapper-2.0:158519): libsystray-CRITICAL **: 17:25:05.864: sn_item_invalidate: assertion 'item->properties_proxy != NULL' failed

(wrapper-2.0:158519): GLib-CRITICAL **: 17:25:05.899: the GVariant format string '(a{sv})' has a type of '(a{sv})' but the given value has a type of '()'

(wrapper-2.0:158519): GLib-CRITICAL **: 17:25:05.899: g_variant_get: assertion 'valid_format_string (format_string, TRUE, value)' failed
xfce4-panel-Message: 17:25:06.139: Plugin systray-23 has been automatically restarted after crash.

(wrapper-2.0:158534): libsystray-CRITICAL **: 17:25:06.331: sn_item_invalidate: assertion 'item->properties_proxy != NULL' failed

(wrapper-2.0:158534): GLib-CRITICAL **: 17:25:06.355: the GVariant format string '(a{sv})' has a type of '(a{sv})' but the given value has a type of '()'

(wrapper-2.0:158534): GLib-CRITICAL **: 17:25:06.355: g_variant_get: assertion 'valid_format_string (format_string, TRUE, value)' failed

(xfce4-panel:158393): GLib-CRITICAL **: 17:25:23.024: g_child_watch_add_full: assertion 'pid > 0' failed

(xfce4-panel:158393): Gtk-CRITICAL **: 17:25:23.033: gtk_icon_theme_load_icon: assertion 'icon_name != NULL' failed

(xfce4-panel:158393): Gtk-CRITICAL **: 17:25:23.040: gtk_icon_theme_load_icon: assertion 'icon_name != NULL' failed

close your panel with command "xfce4-panel -q" and launch it with "PANEL_DEBUG=1 xfce4-panel" to get more information

(wrapper-2.0:212871): libsystray-CRITICAL **: 22:41:23.449: sn_item_invalidate: assertion 'item->properties_proxy != NULL' failed

(wrapper-2.0:212871): GLib-CRITICAL **: 22:41:23.474: the GVariant format string '(a{sv})' has a type of '(a{sv})' but the given value has a type of '()'

(wrapper-2.0:212871): GLib-CRITICAL **: 22:41:23.475: g_variant_get: assertion 'valid_format_string (format_string, TRUE, value)' failed
xfce4-panel(external): systray-6: child exited with status 139
xfce4-panel-Message: 22:41:23.723: Plugin systray-6 has been automatically restarted after crash.
xfce4-panel(external): systray-6: scheduled a respawn of the child
xfce4-panel(external): systray-6: child is unembedded
xfce4-panel(external): systray-6: child spawned; pid=212886, argc=7
xfce4-panel(external): systray-6: child is embedded; 7 properties in queue
xfce4-panel(systray): rgba visual is 0x561e62bcfc50
xfce4-panel(systray): registered manager on screen 0

(wrapper-2.0:212886): libsystray-CRITICAL **: 22:41:23.929: sn_item_invalidate: assertion 'item->properties_proxy != NULL' failed

(wrapper-2.0:212886): GLib-CRITICAL **: 22:41:23.949: the GVariant format string '(a{sv})' has a type of '(a{sv})' but the given value has a type of '()'

(wrapper-2.0:212886): GLib-CRITICAL **: 22:41:23.949: g_variant_get: assertion 'valid_format_string (format_string, TRUE, value)' failed
xfce4-panel(external): systray-6: child exited with status 139
xfce4-panel(external): systray-6: child is unembedded

mentioned in merge request !26 (merged)

assigned to @ochosi

closed with commit e4616236

mentioned in issue panel-plugins/xfce4-statusnotifier-plugin#6 (closed)

mentioned in issue #409 (closed)

changed milestone to %4.17.0

removed 3. Need Info label

marked this issue as related to #409 (closed)

marked this issue as related to panel-plugins/xfce4-statusnotifier-plugin#6 (closed)