Number of rows slider not the same width as other sliders

Submitted by Yousuf Philips @philipzae

Assigned to Xfce Bug Triage

Link to original bug (#15656)

Description

Created attachment 8704 screenshot with red highlighted area

Steps:

1. open panel properties
2. change sliders in Measurements section to their lowest numbers
3. notice the 'Number of rows' slider and slider value label are not aligned with the other 2

Changing the nrows GtkAdjustment from maximum 6 to 100 fixes the visual issue, but this isnt a correct solution.

Tested on Xubuntu 19.10 Daily

Attachment 8704, "screenshot with red highlighted area":

Version: 4.13.5

added 1 deleted label

mentioned in issue #310 (closed)

Still present in xfce4-panel 4.14.3

My reasoning to think this is a bug in GTK:

Sliders glade definitions in xfce4-panel/panel/panel-preferences-dialog.glade

<object class="GtkScale" id="size-scale">
    <property name="visible">True</property>
    <property name="can_focus">True</property>
    <property name="hexpand">True</property>
    <property name="adjustment">size</property>
    <property name="digits">0</property>
    <property name="value_pos">right</property> <!- HERE ->
</object>
(...)
<object class="GtkScale" id="nrows-scale">
    <property name="visible">True</property>
    <property name="can_focus">True</property>
    <property name="hexpand">True</property>
    <property name="adjustment">nrows</property>
    <property name="digits">0</property>
    <property name="value_pos">right</property> <!- HERE ->
</object>
(...)
<object class="GtkScale" id="length-scale">
    <property name="visible">True</property>
    <property name="can_focus">True</property>
    <property name="hexpand">True</property>
    <property name="adjustment">length</property>
    <property name="digits">0</property>
    <property name="value_pos">right</property> <!- HERE ->
</object>

• By default <property name="draw-value">True</property>, that's why is not explicitly declared -> GTK Doc
• The value is shown at the right of the slider as <property name="value_pos">right</property> says.

The difference between nrows and the other 2 is that nrows has a maximum value of 6 (1 digit) while size and length have 128 and 100 (3 digits) respectively.

<object class="GtkAdjustment" id="size">
    <property name="lower">16</property>
    <property name="upper">128</property> <!- HERE ->
    <property name="value">16</property>
    <property name="step_increment">1</property>
    <property name="page_increment">10</property>
</object>
(...)
<object class="GtkAdjustment" id="nrows">
    <property name="lower">1</property>
    <property name="upper">6</property> <!- HERE ->
    <property name="value">1</property>
    <property name="step_increment">1</property>
    <property name="page_increment">1</property>
</object>
(...)
<object class="GtkAdjustment" id="length">
    <property name="lower">1</property>
    <property name="upper">100</property> <!- HERE ->
    <property name="value">25</property>
    <property name="step_increment">1</property>
    <property name="page_increment">10</property>
</object>

My idea is that the space reserved to the right for draw-value is calculated based on the maximum value possible for that slider. That explains why nrows is longer, it has "2 digits more space". This also explains why @philipzae workaround fixes the issue.

But I have no idea how to solve this :/

Ideas:

1. The user should have the ability to set their panel to 100 rows
2. Add 2 spaces between the slider and the value
3. Replace the values with input fields where the user can manually input a value. These input fields auto update when the user moves the slider
4. Replace the sliders entirely and only use input fields like in Appearance -> Fonts -> DPI Selection

The only one that makes sense to me is option 2 of possibly adding a blank label after it with two spaces, assuming this will work as intended.

My idea is that the space reserved to the right for draw-value is calculated based on the maximum value possible for that slider. That explains why nrows is longer, it has "2 digits more space". This also explains why @philipzae workaround fixes the issue.

I was able to confirm my theory using Glade. I created 3 different sliders and the same behaviour happens.

How can I report this to gtk? (should I?)

1. The user should have the ability to set their panel to 100 rows
2. Add 2 spaces between the slider and the value
3. Replace the values with input fields where the user can manually input a value. These input fields auto update when the user moves the slider
4. Replace the sliders entirely and only use input fields like in Appearance -> Fonts -> DPI Selection

More Ideas

1. Set <property name="draw-value">False</property> and use 3 GtkLabel placed to the right of every slider (using GtkGrid maybe), the logic to update those labels should be added to this dialog
2. If the user can only select up to 6 rows, maybe use 6 different buttons, like the Pathbar in Thunar. Elementary has Linked Buttons but i don't know if this is a GTK or Elementary thing

How can I report this to gtk? (should I?)

You can try doing so here - https://gitlab.gnome.org/GNOME/gtk/-/issues

More Ideas

Nice ideas, but this shouldn't get to complicated to fix, so in my view if it isn't a simple fix we can do glade without touching the code, its likely not something we should spend time on.

Elementary has Linked Buttons but i don't know if this is a GTK or Elementary thing.

Its in Gtk as its there in whisker menu's properties dialog.

added 5. Display Settings label

It is now a spinbox in Xfce 4.16.

closed

Fixed in f6e72a85.

changed milestone to %4.15.6

assigned to @ochosi

marked this issue as related to #310 (closed)