Zetta1 Reid0 authored 4 months ago and Gaël Bonithon committed 4 months ago

Fixes: #865

Original mechanism relied on a "ratio" property of clock widgets
and the clock plugin setting a fixed size request. This mechanism
was fragile and resulted in missing size updates. Changed this mechanism
to width_for_height/height_for_width layout. Removed no longer needed
ratio property and added a container-orientation one (the widget has to
be aware of the panel/container orientation for layout purposes).

Also combined the change with size clamping of the LCD and Binary widgets.
Not ideal but it was strongly coupled with the layout mechanism.

Whitespace and comment cleanup

Removed unused function.

Added back "static" + whitespace fix

Maked size/layout of the lcd clock time-independent

LCD clock had a feature where the size of the plugin
could be reduced depending on time of the day.
As a side-effect, other plugins were shifted when the size
of the LCD clock changes.
This commit removes this feature, fixing the clock size.

Made digital clock lines not to spread out in wide panels.

Andrzej authored 4 months ago and Gaël Bonithon committed 4 months ago

Used it in the libxfce4panel and tasklist widget.
Clamping icon size to panel size/nrows moved to libxfce4panel.

Andrzej authored 5 months ago and Gaël Bonithon committed 4 months ago

But clamp them to the button size.

Fixes: #857

This reverts commit 83fa5ead.

Fixes: #860

gdk_display_get_monitor_at_window() is unreliable on wayland, because
when the panel is remapped it usually first appears on one monitor
before being moved to another, and there is no signal or event to
indicate when this process has finished. So it's best to use
gtk_layer_get_monitor() whenever possible, as we always use
gtk_layer_set_monitor() upstream.

Second step: we hide the panel window on Wayland when it's about to be
moved off-screen, either directly or at the end of the animation (the
same applies to external plugins). This eliminates the need for
remapping and manual commit, since as long as the window has not
completely left the screen, it can be brought back without remapping,
and remapping is not necessary either to trigger a resize. See
https://github.com/labwc/labwc/issues/499

It might be preferable to manage animation on Wayland via the viewporter
protocol, as the layer-shell protocol may no longer support negative
margins when it arrives in the ext namespace. Unfortunately, the current
implementation of the viewporter protocol in most compositors doesn't
allow this: see https://github.com/labwc/labwc/issues/2129

This is the right signal wince we're only interested in the monitors on
which the window appears in this case, and this signal works just as
well on X11 as on Wayland, unlike geometry-changed.

Jeremy White authored 8 months ago and Gaël Bonithon committed 8 months ago

Manual arranging of window buttons failed under Wayland,
because tasklist_window_get_xid() provided 0 for all windows,
since Wayland does not provide a window id.

Renamed to tasklist_window_get_wid() and used the window pointer
itself as sufficient proxy for window id.

Fixes: #845

It looks like we want to obtain the label in such way in multiple places.

To make the UX more consistent with other confirmation dialogs.

Fixes https://github.com/shimmerproject/elementary-xfce/issues/450.

tasklist-widget.c:4400:55: warning: Access to field 'data' results in a dereference of a null pointer (loaded from field 'windows') [core.NullDereference]
 4400 |                                                       group_child->windows->data);

I think all calls to xfce_tasklist_group_button_child_visible_changed
are protected, so as it stands it would be a false positive, but that
might change in the future, and this extra check won't bother no matter
what.

Fixes: #839

Nicholas Vinson authored 9 months ago and Gaël Bonithon committed 9 months ago

Commit 0f786ce4 added a math.h include
statement to libxfce4panel/xfce-panel-image.c to fix issue #833.
However, libm functions are used in more files than just
xfce-panel-image.c.

Therefore, add math.h include to other files that use math functions.

Signed-off-by: Nicholas Vinson <nvinson234 at gmail.com>
Fixes: https://bugs.gentoo.org/932303

Viktor Kurilko authored 10 months ago and Gaël Bonithon committed 10 months ago

This patch adds the ability to show the desktop when hovering over the
showdesktop plugin. A configuration dialog for this plugin is also added
which allows for disabling this behavior.

Closes: #517

But preserve it when it's relevant.

Fixes: 0b8777fb

It's probably better to have a few blurred icons than disparate sizes,
and better to avoid an option for that too.

Closes: #678

I'd set it to 24 in 90b8a23f but it's too big. 20 would probably be
nice, but id doesn't seem possible when using GIcon.

Closes: #712

Instead of xfconf_init() without error handling.

It also seems important to preserve a certain elasticity before sending
buttons to the overflow menu. With this commit in addition to the
previous one, the default behavior is the same as before, including for
the overflow menu.

Since 0f43d3f8, the length of the buttons varies between
min-button-length and max-button-length depending on the length of the
labels, which is fine and complies with the documentation, but may not
be what all users want. Setting a minimum length equal to the maximum
length ensures the same default behavior as before, overflow menu aside.

Amends: 0f43d3f8

Better make a separate commit for that too, as I'm still removing quite
a lot, beyond just sorting.

This should have no functional impact, but it's better to subtract it
from the formatting that follows.