Return to the client if a plugin event was handled.

New status: 383 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 383 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

Andrzej authored 13 years ago and Nick Schermer committed 13 years ago

(cherry picked from commit 02520a3af9ade1afe1a28b7a1e73f76a680e037e)

Andrzej authored 13 years ago and Nick Schermer committed 13 years ago

The workaround for wrong pager aspect ratio in the deskbar mode breaks D&D
in the pager and may produce infinite looping (currently it is stable
but that may change with even small changes to the pager requisition/allocation
mechanism).

This commit removes the workaround, which means that:
- the pager aspect ratio in the deskbar mode is only correct when
  libwnck >=2.31.0 is used
- D&D in the pager works again as in panel 4.8.
(cherry picked from commit 67b419fb91e8ffa25d6af25488e75f0d610a54b9)

Andrzej authored 13 years ago and Nick Schermer committed 13 years ago

libwnck pager (2.31.0) has been extended with a versioning api and
a layout policy mechanism. This makes our aspect ratio hack for
pager in a deskbar mode unnecessary.

The modified libwnck version is currently available at:
http://git.gnome.org/browse/libwnck/log/?h=wip/xfce-4.10-fixes
(cherry picked from commit 77c3ac772ec79f3a8020d86db26b7583fd2a9223)

This reverts commit 07fe0a62.

This reverts commit 9430906f.

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 378 messages complete with 0 fuzzies and 2 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

Andrzej authored 13 years ago and Nick Schermer committed 13 years ago

Previous workaround wasn't sufficiently stable. Infinite looping could be
triggered if the user set:

panel size = 16
panel rows = 1
workspace rows = 1
no of workspaces = 100

and then started increasing/decreasing panel size by 1.

This fix rearranges the code (storing last pager height instead
of its aspect ratio) and introduces a minimum WNCK panel height of 10px.
Tbis makes it stable in the above scenario.

Still, we should push for a real fix in the WNCK pager:
https://bugzilla.gnome.org/show_bug.cgi?id=664779

Andrzej authored 13 years ago and Nick Schermer committed 13 years ago

Error introduced in the commit with aspect ratio workaround.
plugin->size was only updated in the deskbar-mode with WNCK pager.

Andrzej authored 13 years ago and Nick Schermer committed 13 years ago

This is to match the workspace ordering in WNCK and button pagers.

Andrzej authored 13 years ago and Nick Schermer committed 13 years ago

This is caused by current limitation of WNCK pager. We can remove
or disable this hack once WNCK pager supports different orientation
of the pager and panel.

Andrzej authored 13 years ago and Nick Schermer committed 13 years ago

Reasons for doing that:
1. it's consistent with other plugins.
2. it isn't exposed in the gui (user has to use xfconf-query tool
   to set it).
3. previous behavior was likely a workaround for lack of desbar mode
   (users which preferred to have the clock horizontal in a vertical
   panel by default are likely to use deskbar mode now).
4. horizontal labels don't fit in narrow vertical panels.

We could perhaps remove this property instead.

Andrzej authored 13 years ago and Nick Schermer committed 13 years ago

Updated to use mode_changed instead of orientation_changed.

The implementation still uses a rotate-vertically property, which isn't
exposed in the gui.

Initialization order in clock_plugin_set_mode has been changed to fix
aspect ratio of binary clock just after changing the clock mode.

Andrzej authored 13 years ago and Nick Schermer committed 13 years ago

Problem:

get_requisition on external plugins returns an old size_request
value when the size of the panel is changed quickly (e.g. when
user controls the "size" slider using cursor keys).

In case of "small" external plugins this means that they are
"losing" their "small" status when the user quickly decreases
the panel size. This is because their get_requisition size
is temporarily larger than the row size. This in turn causes
a lot of flicker when the user changes (decreases) the panel size.

(the above was tested using an xfce4-mixer plugin with a patch from:
https://bugzilla.xfce.org/show_bug.cgi?id=8350 )

Arguably, the itembar doesn't have to check the plugin size, only
the "small" flag. It's then the plugins responsibility to render itself
in such a way it fits in a single row.

The itembar is still using the plugin size to decide the row height.
It may temporarily be incorrect when the panel size changes quickly
but that doesn't cause flicker.

Andrzej authored 13 years ago and Nick Schermer committed 13 years ago

Action buttons size is set to max panel_size / nrows.
Previously buttons were scaled up to the whole panel size,
which was inconsistent with other plugins (app menu, launchers etc).

Andrzej authored 13 years ago and Nick Schermer committed 13 years ago

Regression fix. This error has been triggered by commit:
f362692 panel-itembar: Removed item size checks.

This commit should be harmless. It can be used without commit f362692
and may speed up itembar layout a bit.

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).

New status: 380 messages complete with 0 fuzzies and 0 untranslated.

Transmitted-via: Transifex (translations.xfce.org).