Skip to content

tumblerd: Fix string leaks in tumbler_manager_directory_changed

correctmost requested to merge correctmost/tumbler:cm/fix-dir-changed-leaks into master

Leak report

Direct leak of 64 byte(s) in 4 object(s) allocated from:
  #0 0x7b333f4fd891 in malloc /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_malloc_linux.cpp:69
  #1 0x7b333d6b950d in g_malloc glib/gmem.c:100
  #2 0x7b333d63c9ce in g_path_get_basename glib/gfileutils.c:2636
  #3 0x7b333eb681c4 in g_local_file_get_basename gio/glocalfile.c:293
  #4 0x7b333e86f4d8 in g_file_get_basename gio/gfile.c:567
  #5 0x62277f8b4510 in tumbler_manager_directory_changed tumbler/tumblerd/tumbler-manager.c:1615
[...snip...]

Direct leak of 16 byte(s) in 1 object(s) allocated from:
  #0 0x7b333f4fd891 in malloc /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_malloc_linux.cpp:69
  #1 0x7b333d6b950d in g_malloc glib/gmem.c:100
  #2 0x7b333d63c9ce in g_path_get_basename glib/gfileutils.c:2636
  #3 0x7b333eb681c4 in g_local_file_get_basename gio/glocalfile.c:293
  #4 0x7b333e86f4d8 in g_file_get_basename gio/gfile.c:567
  #5 0x62277f8b3354 in tumbler_manager_directory_changed tumbler/tumblerd/tumbler-manager.c:1569
[...snip...]

Testing

  • No issues were detected when testing the patch with UBSan, LSan, and ASan

Merge request reports