Skip to content

xdg-cache: Fix string leak in xdg_cache_cache_cleanup

correctmost requested to merge correctmost/tumbler:cm/fix-cache-cleanup-leak into master

Leak report

Direct leak of 134 byte(s) in 4 object(s) allocated from:
  #0 0x7f124a4fd891 in malloc /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_malloc_linux.cpp:69
  #1 0x7f12486b950d in g_malloc glib/gmem.c:100
  #2 0x7f1248721930 in g_strdup glib/gstrfuncs.c:323
  #3 0x7f1249b69b0d in g_strdup_inline glib/gstrfuncs.h:321
  #4 0x7f1249b69b0d in g_local_file_get_path gio/glocalfile.c:299
  #5 0x7f124986f690 in g_file_get_path gio/gfile.c:592
  #6 0x7f1246736a47 in xdg_cache_cache_cleanup tumbler/plugins/xdg-cache/xdg-cache-cache.c:219
  #7 0x7f124ab08dd8 in tumbler_cache_cleanup tumbler/tumbler/tumbler-cache.c:94
  #8 0x5fb359b99af5 in tumbler_cache_service_cleanup_thread tumbler/tumblerd/tumbler-cache-service.c:452
  #9 0x7f124874c8d1 in g_thread_pool_thread_proxy glib/gthreadpool.c:336
  #10 0x7f124874ba17 in g_thread_proxy glib/gthread.c:892
  #11 0x7f124a45d109 in asan_thread_start /usr/src/debug/gcc/gcc/libsanitizer/asan/asan_interceptors.cpp:234
  #12 0x7f12478a339c  (/usr/lib/libc.so.6+0x9439c)

Testing

  • No issues were detected when testing the patch with UBSan, LSan, and ASan

Merge request reports