Skip to content

Fix string leak in thunar_emblem_chooser_file_changed

correctmost requested to merge correctmost/thunar:cm/fix-emblem-leak into master

Leak report

Direct leak of 4 byte(s) in 1 object(s) allocated from:
    #0 0x617190f9ff39 in calloc (/usr/asan/bin/thunar+0x457f39)
    #1 0x7b117bfd50ca in g_malloc0 glib/gmem.c:133:13
    #2 0x61719109999c in thunar_emblem_chooser_file_changed thunar/thunar-emblem-chooser.c:428:23
    #3 0x7b117c776310 in _g_closure_invoke_va gobject/gclosure.c:896:7
    #4 0x7b117c7ac5a1 in signal_emit_valist_unlocked gobject/gsignal.c:3423:8
[...snip...]

Steps to reproduce

  • Right-click on a file and choose Properties
  • Add an emblem to the file
  • Close the Properties dialog
  • Right-click on the same file and choose Properties
  • Remove the emblem
  • Close the Properties dialog

Testing

  • No issues were detected with LSan, ASan, or Valgrind when testing the patch

Merge request reports