Skip to content

Fix string leak in thunar_io_jobs_util_next_renamed_file

correctmost requested to merge correctmost/thunar:cm/fix-renamed-str-leak into master

Leak report

Direct leak of 39 byte(s) in 2 object(s) allocated from:
    #0 0x603541cd6a99 in malloc (/usr/asan/bin/thunar+0x498a99)
    #1 0x78128d1d5062 in g_malloc glib/gmem.c:100:13
    #2 0x78128d18c29f in g_path_get_basename glib/gfileutils.c:2636:12
    #3 0x603541ed724a in thunar_io_jobs_util_next_renamed_file thunar/thunar-io-jobs-util.c:169:18
    #4 0x60354209444e in thunar_transfer_job_copy_file thunar/thunar-transfer-job.c:772:30
    #5 0x603542091f8c in thunar_transfer_job_copy_node thunar/thunar-transfer-job.c:953:26
    #6 0x60354208c1d4 in thunar_transfer_job_execute thunar/thunar-transfer-job.c:1730:11
    #7 0x78128f4355f0 in exo_job_scheduler_job_func exo/exo-job.c:310:13
[...snip...]

Steps to reproduce

  • Press Rename on the "Confirm to replace files" dialog

Testing

  • No issues were detected with LSan, ASan, or Valgrind when testing the patch

Merge request reports