Skip to content

Fix string leak in thunar_dialogs_show_job_ask_replace

correctmost requested to merge correctmost/thunar:cm/fix-replace-dlg-leak into master

Leak report

Direct leak of 36 byte(s) in 2 object(s) allocated from:
    #0 0x5acb0b5aa979 in malloc (/usr/asan/bin/thunar+0x498979) (BuildId: ceccbf6cf7ce68ef)
    #1 0x75594f3d5062 in g_malloc glib/gmem.c:100:13
    #2 0x75594f4118d2 in g_strdup glib/gstrfuncs.c:323:17
    #3 0x75594fc8deee in g_strdup_inline glib/gstrfuncs.h:321:10
    #4 0x75594fc8deee in value_lcopy_string gobject/gvaluetypes.c:316:17
    #5 0x75594fc4419d in g_object_get_valist gobject/gobject.c:3271:7
    #6 0x75594fc44a1b in g_object_get gobject/gobject.c:3366:3
    #7 0x5acb0b6fe828 in thunar_dialogs_show_job_ask_replace thunar/thunar/thunar-dialogs.c:797:3
    #8 0x5acb0b848ac2 in thunar_progress_view_ask_replace thunar/thunar/thunar-progress-view.c:506:10
[...snip...]

Testing

  • No issues were detected with LSan, ASan, or Valgrind when testing the patch

Merge request reports