Skip to content

Avoid critical when thumbnailer_proxy is NULL

correctmost requested to merge correctmost/thunar:cm/handle-null-thumbnailer into master

Description

Something is misconfigured with my local build, but I think this fix still makes sense because all of the other thumbnailer->thumbnailer_proxy references check for NULL first.

Messages

thunar-WARNING **: ThunarThumbnailer: Failed to retrieve supported types: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name is not activatable
thunar-WARNING **: Thumbnailer Proxy Failed ... starting attempt to re-initialize
thunar-WARNING **: ThunarThumbnailer: Failed to retrieve supported types: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name is not activatable
thunar-WARNING **: Thumbnailer Proxy Failed ... starting attempt to re-initialize
thunar-WARNING **: Thumbnailer Proxy Failed ... starting attempt to re-initialize
thunar-WARNING **: Thumbnailer Proxy Failed ... starting attempt to re-initialize
thunar-WARNING **: Thumbnailer Proxy Failed ... starting attempt to re-initialize
thunar-WARNING **: Thumbnailer Proxy Failed ... starting attempt to re-initialize
thunar-WARNING **: ThunarThumbnailer: Failed to retrieve supported types: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name is not activatable
thunar-WARNING **: ThunarThumbnailer: Failed to retrieve supported types: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name is not activatable
GLib-GObject-CRITICAL **: invalid (NULL) pointer instance

Backtrace

(gdb) f 4
#4  0x0000555555d9425b in thunar_thumbnailer_received_supported_types (proxy=0x50f00006a470, result=0x5100000ede40, thumbnailer=0x50d00001ad40) at thunar-thumbnailer.c:675
675	      g_signal_handlers_disconnect_by_data (thumbnailer->thumbnailer_proxy, thumbnailer);
(gdb) p thumbnailer->thumbnailer_proxy
$1 = (ThunarThumbnailerDBus *) 0x0

(gdb) bt
#0  g_logv (log_domain=0x7ffff634f4e0 <str> "GLib-GObject", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7ffff2b91b20) at ../glib/gmessages.c:1277
#1  0x00007ffff5bd646c in g_log (log_domain=<optimized out>, log_level=<optimized out>, format=<optimized out>) at ../glib/gmessages.c:1315
#2  0x00007ffff63c3c13 in g_type_check_instance (type_instance=<optimized out>) at ../gobject/gtype.c:4268
#3  0x00007ffff63aa896 in g_signal_handlers_disconnect_matched (instance=0x7ffff4c79870, mask=0, signal_id=1, detail=2, closure=0x31ba2, func=0x0, data=0x50d00001ad40)
    at ../gobject/gsignal.c:2992
#4  0x0000555555d9425b in thunar_thumbnailer_received_supported_types (proxy=0x50f00006a470, result=0x5100000ede40, thumbnailer=0x50d00001ad40) at thunar-thumbnailer.c:675
#5  0x00007ffff60e1fcc in g_task_return_now (task=task@entry=0x5100000ede40) at ../gio/gtask.c:1361
#6  0x00007ffff60df3af in g_task_return (task=0x5100000ede40, type=<optimized out>) at ../gio/gtask.c:1430
#7  0x00007ffff61ba3cb in reply_cb (connection=<optimized out>, res=<optimized out>, user_data=<optimized out>) at ../gio/gdbusproxy.c:2545
#8  0x00007ffff60e1fcc in g_task_return_now (task=task@entry=0x5100000edf40) at ../gio/gtask.c:1361
#9  0x00007ffff60df3af in g_task_return (task=0x5100000edf40, type=<optimized out>) at ../gio/gtask.c:1430
#10 0x00007ffff61a0c7d in g_dbus_connection_call_done (source=0x5110000016c0, result=<optimized out>, user_data=0x5100000edf40) at ../gio/gdbusconnection.c:6344
#11 0x00007ffff60e20dc in g_task_return_now (task=0x5100000ee040) at ../gio/gtask.c:1361
#12 complete_in_idle_cb (task=0x5100000ee040) at ../gio/gtask.c:1375
#13 0x00007ffff5bc1103 in g_main_dispatch (context=0x511000001800) at ../glib/gmain.c:3357
#14 g_main_context_dispatch_unlocked (context=0x511000001800) at ../glib/gmain.c:4208
#15 0x00007ffff5bc1dd0 in g_main_context_iterate_unlocked (context=0x511000001800, block=<optimized out>, dispatch=<optimized out>, self=<optimized out>) at ../glib/gmain.c:4273
#16 0x00007ffff5bc2026 in g_main_context_iteration (context=context@entry=0x511000001800, may_block=may_block@entry=1) at ../glib/gmain.c:4338
#17 0x00007ffff6137cd2 in g_application_run (application=<optimized out>, argc=<optimized out>, argv=<optimized out>) at ../gio/gapplication.c:2715
#18 0x0000555555a73824 in main (argc=1, argv=0x7fffffffe4a8) at main.c:86

Merge request reports