Skip to content

Fix string leak in thunar_uca_model_remove

correctmost requested to merge correctmost/thunar:cm/fix-uca-model-leak into master

Leak report

Direct leak of 19 byte(s) in 1 object(s) allocated from:
    #0 0x6394253c5919 in malloc (/usr/asan/bin/thunar+0x498919)
    #1 0x7aa9243d5062 in g_malloc glib/gmem.c:100:13
    #2 0x7aa9244118d2 in g_strdup glib/gstrfuncs.c:323:17
    #3 0x7aa924c8deee in g_strdup_inline glib/gstrfuncs.h:321:10
    #4 0x7aa924c8deee in value_lcopy_string gobject/gvaluetypes.c:316:17
    #5 0x7aa925b533f6 in gtk_tree_model_get_valist gtk/gtktreemodel.c:1812:7
    #6 0x7aa925b52a3e in gtk_tree_model_get gtk/gtktreemodel.c:1774:3
    #7 0x7aa92274f732 in thunar_uca_model_remove thunar/plugins/thunar-uca/thunar-uca-model.c:1346:3
    #8 0x7aa92273f488 in thunar_uca_chooser_delete_clicked thunar/plugins/thunar-uca/thunar-uca-chooser.c:384:11
[...snip...]

Steps to reproduce

  • Edit > Configure custom actions
  • Remove an existing custom action

Testing

  • No issues were detected with LSan, ASan, or Valgrind when testing the patch

Merge request reports