Skip to content

Fix AtkRelationSet leaks in bulk renamer dialog

correctmost requested to merge correctmost/thunar:cm/fix-bulk-renamer-leaks into master

Example leak report

Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x5e5f974bcc59 in calloc (/usr/asan/bin/thunar+0x498c59) (BuildId: 3f919e039cb60031)
    #1 0x7d02d5d46b62 in g_malloc0 /usr/src/debug/glib2/build/../glib/glib/gmem.c:133:13
    #2 0x7d02d5cc27b5 in g_type_create_instance /usr/src/debug/glib2/build/../glib/gobject/gtype.c:1933:17
    #3 0x7d02d5ca7684 in g_object_new_internal /usr/src/debug/glib2/build/../glib/gobject/gobject.c:2606:24
    #4 0x7d02d5ca8cfe in g_object_new_internal /usr/src/debug/glib2/build/../glib/gobject/gobject.c:2603:6
    #5 0x7d02d5ca8cfe in g_object_new_with_properties /usr/src/debug/glib2/build/../glib/gobject/gobject.c:2769:14
    #6 0x7d02d5ca9d51 in g_object_new /usr/src/debug/glib2/build/../glib/gobject/gobject.c:2415:12
    #7 0x7d02d76edf6c in atk_object_init /usr/src/debug/at-spi2-core/build/../at-spi2-core/atk/atkobject.c:659:30
    #8 0x7d02d5cc280a in g_type_create_instance /usr/src/debug/glib2/build/../glib/gobject/gtype.c:1945:4
    #9 0x7d02d5ca7684 in g_object_new_internal /usr/src/debug/glib2/build/../glib/gobject/gobject.c:2606:24
    #10 0x7d02d5ca997a in g_object_new_internal /usr/src/debug/glib2/build/../glib/gobject/gobject.c:2923:29
    #11 0x7d02d5ca997a in g_object_new_valist /usr/src/debug/glib2/build/../glib/gobject/gobject.c:2945:16
    #12 0x7d02d5ca9d2f in g_object_new /usr/src/debug/glib2/build/../glib/gobject/gobject.c:2418:12
    #13 0x7d02d6e09e6a in gtk_widget_real_get_accessible gtk/gtkwidget.c:13566:24
    #14 0x7d02ce1823bc in thunar_sbr_replace_renamer_init thunar/plugins/thunar-sbr/thunar-sbr-replace-renamer.c:226:44
[...snip...]

Testing

  • No issues were detected with LSan, ASan, or Valgrind when testing the patch

Merge request reports