Skip to content

Fix leak in thunar_details_view_button_press_event

correctmost requested to merge correctmost/thunar:cm/fix-mouse-back-leak into master

This leak occurred when using a mouse back button to navigate directories.

Leak report

Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x651fecafb919 in malloc (/usr/asan/bin/thunar+0x498919) (BuildId: 3f919e039cb60031)
    #1 0x7bf5e58dce4a in g_malloc /usr/src/debug/glib2/build/../glib/glib/gmem.c:100:13
    #2 0x7bf5e694cf2f in gtk_tree_path_new gtk/gtk/gtktreemodel.c:606:12
    #3 0x7bf5e6989348 in _gtk_tree_path_new_from_rbtree gtk/gtk/gtktreeview.c:9756:10
    #4 0x7bf5e699adc6 in gtk_tree_view_get_path_at_pos gtk/gtk/gtktreeview.c:13658:13
    #5 0x651fecc3f992 in thunar_details_view_button_press_event thunar/thunar/thunar-details-view.c:799:11
    #6 0x7bf5e63c426c in _gtk_marshal_BOOLEAN__BOXED gtk/builddir/gtk/gtkmarshalers.c:84:14
    #7 0x7bf5e582c699 in g_closure_invoke /usr/src/debug/glib2/build/../glib/gobject/gclosure.c:834:7
    #8 0x7bf5e585d2a4 in signal_emit_unlocked_R.isra.0 /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3888:8
    #9 0x7bf5e584d25f in signal_emit_valist_unlocked /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3533:7
[...snip...]

Testing

  • No issues were detected with LSan, ASan, or Valgrind when testing the patch

Merge request reports