Skip to content

Fix leak when middle-clicking on directory row

correctmost requested to merge correctmost/thunar:cm/fix-middle-click-leak into master

Leak report

Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x5a3270eb07f9 in malloc (/usr/asan/bin/thunar+0x4987f9) (BuildId: de5a685fd75399b9)
    #1 0x73eae77ffe4a in g_malloc /usr/src/debug/glib2/build/../glib/glib/gmem.c:100:13
    #2 0x73eae894cf2f in gtk_tree_path_new gtk/gtktreemodel.c:606:12
    #3 0x73eae8989348 in _gtk_tree_path_new_from_rbtree gtk/gtktreeview.c:9756:10
    #4 0x73eae899adc6 in gtk_tree_view_get_path_at_pos gtk/gtktreeview.c:13658:13
    #5 0x5a3270ff485b in thunar_details_view_button_press_event thunar/thunar/thunar-details-view.c:799:11
    #6 0x73eae83c426c in _gtk_marshal_BOOLEAN__BOXED gtk/builddir/gtk/gtkmarshalers.c:84:14
    #7 0x73eae774f699 in g_closure_invoke /usr/src/debug/glib2/build/../glib/gobject/gclosure.c:834:7
    #8 0x73eae77802a4 in signal_emit_unlocked_R.isra.0 /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3888:8
    #9 0x73eae777025f in signal_emit_valist_unlocked /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3533:7
    #10 0x73eae7770c71 in g_signal_emit_valist /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3263:7
    #11 0x73eae7770d33 in g_signal_emit /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3583:3
    #12 0x73eae89ecebf in gtk_widget_event_internal gtk/gtkwidget.c:7812:4
    #13 0x73eae86e746e in propagate_event_up gtk/gtkmain.c:2588:25
    #14 0x73eae86e746e in propagate_event gtk/gtkmain.c:2691:5
    #15 0x73eae86e746e in gtk_propagate_event gtk/gtkmain.c:2725:3
    #16 0x73eae86e63d4 in gtk_main_do_event gtk/gtkmain.c:1921:9
    #17 0x73eae8f10b70 in _gdk_event_emit gdk/gdkevents.c:73:5
    #18 0x73eae8fd0129 in gdk_event_source_dispatch gdk/x11/gdkeventsource.c:367:7
    #19 0x73eae77fa298 in g_main_dispatch /usr/src/debug/glib2/build/../glib/glib/gmain.c:3344:28
    #20 0x73eae785cec6 in g_main_context_dispatch_unlocked /usr/src/debug/glib2/build/../glib/glib/gmain.c:4152:7
    #21 0x73eae785cec6 in g_main_context_iterate_unlocked.isra.0 /usr/src/debug/glib2/build/../glib/glib/gmain.c:4217:5
    #22 0x73eae77f9794 in g_main_context_iteration /usr/src/debug/glib2/build/../glib/glib/gmain.c:4282:12
    #23 0x73eae79ca195 in g_application_run /usr/src/debug/glib2/build/../glib/gio/gapplication.c:2712:7
    #24 0x5a3270f37703 in main thunar/thunar/main.c:86:3
    #25 0x73eae7572e07 in __libc_start_call_main /usr/src/debug/glibc/glibc/csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #26 0x73eae7572ecb in __libc_start_main /usr/src/debug/glibc/glibc/csu/../csu/libc-start.c:360:3
    #27 0x5a3270dc4714 in _start (/usr/asan/bin/thunar+0x3ac714) (BuildId: de5a685fd75399b9)

Testing

  • No issues were detected with LSan, ASan, or Valgrind when testing the patch

Merge request reports