Skip to content

Fix leak in thunar_details_view_button_press_event

correctmost requested to merge correctmost/thunar:cm/fix-path-leak into master

This leak occurred when clicking on an expander with 'Single click to activate items' enabled.

Leak report

Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x5f95fec017f9 in malloc (/usr/asan/bin/thunar+0x4987f9)
    #1 0x7d504407be4a in g_malloc /usr/src/debug/glib2/build/../glib/glib/gmem.c:100:13
    #2 0x7d504514cf2f in gtk_tree_path_new gtk/gtktreemodel.c:606:12
    #3 0x7d5045189348 in _gtk_tree_path_new_from_rbtree gtk/gtktreeview.c:9756:10
    #4 0x7d504519adc6 in gtk_tree_view_get_path_at_pos gtk/gtktreeview.c:13658:13
    #5 0x5f95fed4585b in thunar_details_view_button_press_event thunar/thunar/thunar-details-view.c:799:11
    #6 0x7d5044bc426c in _gtk_marshal_BOOLEAN__BOXED gtk/builddir/gtk/gtkmarshalers.c:84:14
    #7 0x7d5043fcb699 in g_closure_invoke /usr/src/debug/glib2/build/../glib/gobject/gclosure.c:834:7
    #8 0x7d5043ffc2a4 in signal_emit_unlocked_R.isra.0 /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3888:8
    #9 0x7d5043fec25f in signal_emit_valist_unlocked /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3533:7
    #10 0x7d5043fecc71 in g_signal_emit_valist /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3263:7
    #11 0x7d5043fecd33 in g_signal_emit /usr/src/debug/glib2/build/../glib/gobject/gsignal.c:3583:3
[...snip...]

Testing

  • No issues were detected with LSan, ASan, or Valgrind when testing the patch

Merge request reports